chore: Skip unit tests dependency when running publish image workflow

[ericallam]

Summary by CodeRabbit

• Chores
  • Updated workflow dependencies to streamline the publishing process.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 7c595f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The workflow configuration file .github/workflows/publish.yml was updated to remove the dependency on the units job for the publish-webapp, publish-worker, and publish-worker-v4 jobs. These jobs now only depend on the completion of the typecheck job before execution.

Changes

File(s)	Change Summary
.github/workflows/publish.yml	Removed units job from the needs attribute of publish-webapp, publish-worker, and publish-worker-v4 jobs; they now depend solely on typecheck.

Sequence Diagram(s)

sequenceDiagram
    participant typecheck as typecheck job
    participant publish_webapp as publish-webapp job
    participant publish_worker as publish-worker job
    participant publish_worker_v4 as publish-worker-v4 job

    typecheck->>publish_webapp: triggers on completion
    typecheck->>publish_worker: triggers on completion
    typecheck->>publish_worker_v4: triggers on completion

Loading

Possibly related PRs

• chore: publish docker even if the unit tests fail for now #1867: Extends the removal of the units job dependency to the publish-worker-v4 job, building on similar workflow dependency changes.

Poem

🐇
The units job hops away,
While typecheck alone clears the way.
Webapp and workers now run free,
Chained to just one dependency.
In the garden of workflows, neat and light,
Publishing hops forward, swift and bright!

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

♻️ Duplicate comments (2)

.github/workflows/publish.yml (2)

66-66: Duplicate: validate skipping unit-tests for publish-worker
Same as publish-webapp, ensure publish-worker can safely proceed without waiting on the units job.

---

73-73: Duplicate: validate skipping unit-tests for publish-worker-v4
Same as above, confirm that removing units from publish-worker-v4 aligns with your release strategy.

🧹 Nitpick comments (1)

.github/workflows/publish.yml (1)

59-59: Validate skipping unit-tests dependency for publish-webapp
By removing units from needs, the publish-webapp job will no longer wait for unit tests to pass, which may allow publishing images even if tests fail. Confirm this decoupling is intentional and that test failures are handled in another workflow or gating mechanism.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2ae0e22 and 7c595f3.

📒 Files selected for processing (1)

• .github/workflows/publish.yml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
• GitHub Check: units / 🧪 Unit Tests
• GitHub Check: typecheck / typecheck