Skip to content

Fix init.ts import for deployed workers #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 13, 2025
Merged

Fix init.ts import for deployed workers #2041

merged 7 commits into from
May 13, 2025

Conversation

nicktrn
Copy link
Collaborator

@nicktrn nicktrn commented May 13, 2025

We just didn't import the bloody thing. Also improved errors when managed worker configured incorrectly.

Fixes: #2037

Summary by CodeRabbit

  • Bug Fixes

    • Improved error handling and messaging for worker task execution failures.
    • Fixed issues with auto-import functionality for deployed workers.
  • Chores

    • Updated internal logic to support an optional initialization entry point for workers.
    • Adjusted the order of certain internal processes for improved reliability.

Copy link

changeset-bot bot commented May 13, 2025

🦋 Changeset detected

Latest commit: 2059c71

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

coderabbitai bot commented May 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This update introduces a changeset describing a patch fix for the auto-import of init.ts in deployed workers. In the codebase, the managed worker now conditionally imports an initialization file before loading the main task entry point, with improved error reporting. The order of certain initializations and IPC handlers is also adjusted.

Changes

File(s) Change Summary
.changeset/twelve-actors-hide.md Added a changeset describing a patch fix for init.ts auto-import in deployed workers.
packages/cli-v3/src/entryPoints/dev-run-worker.ts Swapped the initialization order of standardRunTimelineMetricsManager and lifecycle hooks manager.
packages/cli-v3/src/entryPoints/managed-run-worker.ts Added conditional import of workerManifest.initEntryPoint before main entry; improved error handling; reordered and simplified IPC handlers.
packages/cli-v3/src/build/buildWorker.ts Updated rewriteBuildManifestPaths to handle optional initEntryPoint by rewriting its path if present.

Sequence Diagram(s)

sequenceDiagram
    participant Worker
    participant InitFile
    participant TaskEntry
    participant Logger

    Worker->>InitFile: Conditionally import initEntryPoint
    alt Import succeeds
        InitFile-->>Logger: Log success
    else Import fails
        InitFile-->>Logger: Log failure
        InitFile-->>Worker: Throw error (propagate)
    end
    Worker->>TaskEntry: Import main task entry point
    TaskEntry-->>Worker: Execute task
    Note over Worker,Logger: Enhanced error handling logs message and stack trace if errors occur
Loading

Assessment against linked issues

Objective Addressed Explanation
Fix bug where middleware/lifecycle hooks in init.ts are not picked up for deployed tasks (#2037)

Possibly related PRs

Suggested reviewers

  • ericallam

Poem

A bunny hops through worker code,
Importing init.ts on the road.
If errors appear, logs will show,
Stack traces clear, so all will know.
With handlers neat and changes set,
This patch ensures no bug is met!
🐇✨

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b3bf5e and 2059c71.

📒 Files selected for processing (1)
  • packages/cli-v3/src/build/buildWorker.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nicktrn nicktrn merged commit bb96e84 into main May 13, 2025
10 checks passed
@nicktrn nicktrn deleted the fix/initdotts branch May 13, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TRI-5377] bug: [v4] Middleware/lifecycle hooks defined in the init.ts file aren't picked up for deployed tasks
2 participants