Skip to content

Loading bar divider – small animation improvement #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

samejr
Copy link
Member

@samejr samejr commented May 1, 2025

Small improvement to the LoadingBarDivider animation

  • It now only moves from left to right – no more ping pong which felt like anti progress
  • Feels smoother and more of it is visible
CleanShot.2025-05-01.at.19.11.44.mp4

Summary by CodeRabbit

  • Style
    • Improved the visual appearance of the loading bar divider by refining its animation for smoother and more continuous movement. Overflow is now properly hidden for a cleaner look.

Copy link

changeset-bot bot commented May 1, 2025

⚠️ No Changeset found

Latest commit: 54adea0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented May 1, 2025

Walkthrough

The changes update the LoadingBarDivider component by adding an overflow-hidden style to its container and simplifying the animation logic within the AnimationDivider subcomponent. The previous two-step animation sequence (width and position) is replaced by a single, continuous animation that moves the element horizontally from left to right while maintaining full width. The animation duration is also adjusted from two short steps to one longer cycle. No changes are made to the exported function signatures.

Changes

File(s) Change Summary
apps/webapp/app/components/primitives/LoadingBarDivider.tsx Added overflow-hidden to container; refactored AnimationDivider to use a single, continuous left-to-right animation with updated timing.

Poem

A loading bar glides from left to right,
Overflow hidden, out of sight.
No more steps, just one smooth run,
Two seconds pass, the work is done.
Animation flows, the code refined—
A rabbit hops with peace of mind! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df0bce3 and 54adea0.

📒 Files selected for processing (1)
  • apps/webapp/app/components/primitives/LoadingBarDivider.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
  • GitHub Check: units / 🧪 Unit Tests
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
apps/webapp/app/components/primitives/LoadingBarDivider.tsx (2)

10-10: Good addition of overflow-hidden to contain the animation

Adding overflow-hidden ensures the animation is contained within its boundaries, which is a clean approach for animations that move outside the container's dimensions.


24-26: Great simplification of the animation logic

The animation changes successfully implement the PR objectives:

  1. The animation now moves only from left to right (from -100% to 100%)
  2. The fixed width of 100% ensures the gradient bar maintains consistent appearance
  3. The 2-second duration with easeOut provides a smoother loading indicator
  4. The animation repeats infinitely without the previous "ping-pong" effect

This creates a more intuitive loading experience that better communicates progress.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@matt-aitken matt-aitken merged commit 2448242 into main May 1, 2025
12 checks passed
@matt-aitken matt-aitken deleted the page-loading-animation-update branch May 1, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants