Support solo buttons in table row #1840

samejr · 2025-03-28T12:40:47Z

Adds a new option for displaying a single button that shows on hover in a table cell.

Also removes an old fallback condition for making sure v2 tables still worked

Before:

After:

Summary by CodeRabbit

New Features
- The schedules page now features an updated link button with an icon and clearer labeling ("Schedules docs") for improved usability.
Style
- Enhanced table menus with refined hover effects and consistent spacing for a cleaner, more responsive look.
- Simplified the display of extra button options for a streamlined interface.

changeset-bot · 2025-03-28T12:40:51Z

⚠️ No Changeset found

Latest commit: 7028329

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-03-28T12:40:55Z

Walkthrough

This change updates various UI components across the webapp. In the Table component, the import for ReactNode is modified to a type import, CSS classes in the TableCellMenu have been adjusted, and the logic for rendering hidden buttons has been simplified by removing an unnecessary popover. In the TaskRunsTable component, the wrapper for hidden buttons is replaced with a React fragment. Additionally, the LinkButton in the schedules route now includes a LeadingIcon (BookOpenIcon) and updated text for better clarity.

Changes

File(s)	Change Summary
`apps/webapp/app/components/primitives/Table.tsx` `apps/webapp/app/components/runs/v3/TaskRunsTable.tsx`	* Table.tsx: Changed the import of `ReactNode` to a type import; updated the `menuButtonDivider` style from `border-grid-dimmed` to `border-grid-bright`; adjusted logic for conditionally applying classes and removed popover rendering logic. * TaskRunsTable.tsx: Replaced a `<div>` wrapping hidden buttons with a React fragment, maintaining the same rendering logic.
`apps/webapp/app/routes/.../route.tsx`	Enhanced the `LinkButton` component in the `InfoPanel` by adding a new `LeadingIcon` prop with `BookOpenIcon` and updating the button text from "Docs" to "Schedules docs".

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TableCellMenu
    participant ButtonRenderer

    User->>TableCellMenu: Initiates interaction
    TableCellMenu->>ButtonRenderer: Checks for hidden buttons and popover content
    alt Hidden buttons present
        ButtonRenderer-->>TableCellMenu: Render hidden buttons wrapped in flex layout with conditional classes
    else No hidden buttons
        TableCellMenu-->>User: Render component without popover
    end

sequenceDiagram
    participant User
    participant InfoPanel
    participant LinkButton

    User->>InfoPanel: Navigates to schedule page
    InfoPanel->>LinkButton: Renders LinkButton with props: to, variant, LeadingIcon=BookOpenIcon, text="Schedules docs"
    LinkButton-->>User: Displays enhanced link button

Possibly related PRs

Full width tables #1474: Updates to the TableCellMenu component that affect its structure and functionality.
3 small improvements #1560: Modifications in how hidden buttons are rendered within the TableCellMenu component.
Side menu and Org dropdown improvements #1801: Changes targeting the rendering of hidden buttons in TableCellMenu, aligning with the logic adjustments in this PR.

Suggested reviewers

matt-aitken

Poem

I'm a hopping rabbit, leaping through the code,
Tables now refined, in every node.
Hidden buttons align with a gentle flex flow,
Icons and labels now extra aglow.
In the garden of commits, these changes make me glow!
🐇✨ Happy coding in our burrow of improvements!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c9a22f and 7028329.

📒 Files selected for processing (3)

apps/webapp/app/components/primitives/Table.tsx (3 hunks)
apps/webapp/app/components/runs/v3/TaskRunsTable.tsx (2 hunks)
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.schedules.$scheduleParam/route.tsx (1 hunks)

✅ Files skipped from review due to trivial changes (1)

apps/webapp/app/components/runs/v3/TaskRunsTable.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

apps/webapp/app/components/primitives/Table.tsx

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
GitHub Check: typecheck / typecheck
GitHub Check: units / 🧪 Unit Tests
GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (1)

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.schedules.$scheduleParam/route.tsx (1)

361-367: Enhanced button presentation and clarity

The LinkButton has been improved with the addition of a BookOpenIcon as a leading icon and more descriptive text. These changes align well with the PR's goal of supporting solo buttons in table rows, making the button more visually distinctive and its purpose clearer to users.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

… new property

samejr added 2 commits March 28, 2025 12:36

Removed old condition that handled old v2 tables

54dd351

Adds support for a single button to be shown on hover in a table cell

9c9a22f

samejr added 2 commits March 28, 2025 13:38

Makes the “hiddenButtons” support a single button instead of adding a…

1e4c080

… new property

Format the docs link for Schedules like the other for consistency

7028329

matt-aitken approved these changes Mar 28, 2025

View reviewed changes

matt-aitken merged commit 73b41c2 into main Mar 28, 2025
12 checks passed

matt-aitken deleted the Support-solo-buttons-in-table-row branch March 28, 2025 15:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Support solo buttons in table row #1840

Support solo buttons in table row #1840

Uh oh!

samejr commented Mar 28, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Mar 28, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 28, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Support solo buttons in table row #1840

Support solo buttons in table row #1840

Uh oh!

Conversation

samejr commented Mar 28, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

samejr commented Mar 28, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Mar 28, 2025 •

edited

Loading

coderabbitai bot commented Mar 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)