-
-
Notifications
You must be signed in to change notification settings - Fork 727
Softened the language in the Pro upgrade modal #1574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
apps/webapp/app/routes/resources.orgs.$organizationSlug.select-plan.tsxOops! Something went wrong! :( ESLint: 8.45.0 ESLint couldn't find the config "custom" to extend from. Please check that the name of the config is correct. The config "custom" was referenced from the config file in "/.eslintrc.js". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/webapp/app/routes/resources.orgs.$organizationSlug.select-plan.tsx (1)
664-676
: Consider adding a brief benefit statement.While the current changes are good, consider enhancing the upgrade message by briefly highlighting a key benefit of the Pro plan. This could help users make a more informed decision.
<DialogHeader>Upgrade plan</DialogHeader> <div className="mb-2 mt-4 flex items-start gap-3"> <span> <ArrowUpCircleIcon className="size-12 text-primary" /> </span> <Paragraph variant="base/bright" className="text-text-bright"> + Take your workflow to the next level with advanced features. Upgrade to get instant access to all the Pro features. You will be charged the new plan price for the remainder of this month on a pro rata basis. </Paragraph> </div>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/webapp/app/routes/resources.orgs.$organizationSlug.select-plan.tsx
(1 hunks)
🔇 Additional comments (2)
apps/webapp/app/routes/resources.orgs.$organizationSlug.select-plan.tsx (2)
664-664
: LGTM! Dialog content changes align with PR objectives.
The changes successfully soften the language by:
- Removing the question mark from "Upgrade plan" header
- Rewording the explanation to be more informative and less intimidating
Also applies to: 670-671
676-676
: LGTM! Button text change improves UX.
Changing "Cancel" to "Dismiss" is a good improvement as it:
- Uses less aggressive language
- Better describes the action (dismissing the dialog rather than canceling the upgrade)
- Maintains consistency with modern UX patterns
@trigger.dev/build
trigger.dev
@trigger.dev/rsc
@trigger.dev/react-hooks
@trigger.dev/core
@trigger.dev/sdk
commit: |
Improved the lauguage in the upgrade to Pro modal:
Summary by CodeRabbit
New Features
Bug Fixes