-
-
Notifications
You must be signed in to change notification settings - Fork 713
Full width tables #1474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Full width tables #1474
Changes from all commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
457a29c
Updated styling
samejr edba9c1
Updated the main Table component styles to the new design
samejr 893874b
Run page table layout style updates
samejr 3c90d9b
Updated row styling and new scrolling behaviour
samejr a02df2c
Fixed bulk action bar no appearing
samejr ec37ba4
Improved table component styles
samejr 564bdbf
Pagination arrows now chevrons
samejr 6d445c3
Added link to Runs docs page
samejr 671a554
Small popover tweak
samejr 7ecf336
Moved the extra Test button out of Tables and into the RunsTable
samejr c9ffd21
WIP refactoring the sticky table cell
samejr 5063d61
Support for the existing way we have menus in the sticky table cells
samejr a57188e
Created a specific Docs style button
samejr 72e727c
Improved dialog trigger button styles
samejr 18ba2ef
Improved docs button styles
samejr 51741c7
Updated Docs buttons to the new style in the tooltips
samejr 3373f34
Adding a Test button on hover
samejr 92aa8f7
Removed the page padding and made table scroll
samejr 36497f0
Fixed table scrolling
samejr f4cba71
cleaned up imports
samejr 1574e69
WIP adding a test button that links to the test page
samejr 37d489b
added a docs button to the header
samejr 1a6e10b
Much nicer display bar for showing how many schedules you have (and i…
samejr 4ff5ebb
Fixed the button types in the schedules info panel
samejr 85a6931
Fixed button icon colour
samejr ef3fda6
Removed the pagination as it’s not being used
samejr 15609b2
Delete modal button position updated
samejr 4525993
Fixed padding on recent payloads panel
samejr e882c4e
Fixed button icon colours
samejr 2addde1
Better style for active table row
samejr 6c6f865
Table scrolling now behaves properly
samejr e296158
environment buttons now have a hover state
samejr 515e573
Bigger Run test bar to match the Run page
samejr 2e299e2
Small layout fixes to the schedule side panel
samejr 8385a34
Test page now has link to docs
samejr 4aacf7d
fixed text alignment with table headers
samejr ba2ee10
API keys page now has full width tables
samejr 95b4d42
Fix typo and modal layout
samejr a553a9f
Table uses new sticky button type
samejr 970787f
Tidy imports
samejr 7f561f4
Env var table now full width
samejr 424c0ca
Form buttons have a border top
samejr dbacd43
Updated button styles
samejr d921c04
Updated blank state message style to be consistent
samejr 5869cb7
Removed unnecessary form button border
samejr e64cca2
Alerts page tables now full width
samejr 5e18441
Allowing the Detail cell to be styled
samejr 21536bb
Updated the page structure to be the same as the scheduled page – wit…
samejr b6d8682
Concurrency limits page now full width
samejr 26c20de
Fixed function name label extending too far
samejr 76c2d1d
Improved the button sizes on the replay modal
samejr 819df8f
Added a minimal style to the info panels
samejr 6861039
Make sure you can always see the info and unlock staging info when th…
samejr b9e21a1
Info panel style updated to match the others
samejr 9c5b320
Removed the duplicate header
samejr a8852df
Usage page tables now full width
samejr 4d41ab5
Personal access token page using full width tables
samejr 1e9714b
Small CSS fixes
samejr a4cb657
Deployments page table now full width
samejr 39db0e2
Deploy page scrolls properly and pagination stays on screen if table …
samejr 4dd6dcd
TableCellMenu using the correct popover
samejr 0d7f533
Added missing button variant
samejr c2145ae
Button group is now named so it doesn’t cause conflicts
samejr 98575a0
Added docs link to the Run page
samejr 29321a2
Typo
samejr af9c439
Added a link to the test page if you have no runs
samejr 3fe3792
Make the table sticky cell buttons more obvious
samejr e6de253
Env var page now using the new popover menu
samejr ce442b1
Improved the menu items
samejr bf9115d
Copy tweak
samejr a20136e
Made the icons bright on hover
samejr afa5636
Updated the cancel run dialog
samejr ac162ec
Improved the API keys sticky menu behaviour
samejr 58515aa
Alerts table menu using the new popover
samejr 0069b71
Correct sized buttons in the Env Var page table menu
samejr eabeadd
Fixed weird Dialog text styling
samejr cc76688
Schedules page blank state using correct docs button style
samejr 638f959
Copy tweak
samejr 2a8fa93
Menu buttons styled correctly
samejr 7f993c2
Added close buttons to the deploy dialogs
samejr 3092406
Made the Dialog footer match the Form footer style
samejr 4db88cc
Fixed feedback form buttons
samejr 87c7eb9
Fixed cancel run dialog
samejr 19aa804
Merge remote-tracking branch 'origin/main' into full-width-tables
matt-aitken 4c2890a
Test page uses the taskIdentifier in the path
matt-aitken 9dfa995
Test task button working
matt-aitken 63be29f
Added Spline component for 404 logo to remove spline logo
samejr c39ee74
Removed todo comment
samejr d9bdc94
Added a docs button to the PAT page
samejr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Based on the gathered information, I can now provide the final response:
Spline scene implementation needs error handling and loading states
The current implementation in
ErrorDisplay.tsx
lacks proper error handling and loading states for the Spline scene. While the component is wrapped in a motion.div for animation, it should:Example locations requiring attention:
apps/webapp/app/components/ErrorDisplay.tsx
: Add error boundary and loading state for Spline scene🔗 Analysis chain
Consider security and reliability improvements for the Spline scene.
The direct loading of a remote Spline scene raises several concerns:
Let's verify the usage of Spline across the codebase:
Let me gather more information about error handling and loading states in the codebase.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 433
Script:
Length of output: 6489