Skip to content

allow where clauses in unit structs #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

m4rch3n1ng
Copy link
Contributor

@m4rch3n1ng m4rch3n1ng commented Apr 2, 2025

can't get the ci to work so here's another feature. not sure why this would be helpful in real life, but it can be done in stable rust so sure.

diff for #229:

straight up diffing it
--- .tmp/list.txt	2025-04-02 20:15:56.614898554 +0200
+++ .tmp/list.txt.unit-struct-where-clauses	2025-04-02 20:19:44.824375365 +0200
@@ -108,7 +108,6 @@
 tests/ui/const-generics/generic_const_exprs/issue-74634.rs
 tests/ui/const-generics/generic_const_exprs/issue-80561-incorrect-param-env.rs
 tests/ui/const-generics/generic_const_exprs/issue-84408.rs
-tests/ui/const-generics/generic_const_exprs/issue-90847.rs
 tests/ui/const-generics/generic_const_exprs/issue-97047-ice-1.rs
 tests/ui/const-generics/generic_const_exprs/issue-97047-ice-2.rs
 tests/ui/const-generics/generic_const_exprs/nested-abstract-consts-2.rs
@@ -222,7 +221,6 @@
 tests/ui/explicit-tail-calls/ctfe-collatz-multi-rec.rs
 tests/ui/explicit-tail-calls/return-lifetime-sub.rs
 tests/ui/explicit-tail-calls/two-phase.rs
-tests/ui/feature-gates/feature-gate-trivial_bounds-lint.rs
 tests/ui/for-loop-while/loop-break-value.rs
 tests/ui/generic-associated-types/collections.rs
 tests/ui/generic-const-items/assoc-const-AnonConst-ice-108220.rs
@@ -403,8 +401,6 @@
 tests/ui/traits/winnowing/global-non-global-env-3.rs
 tests/ui/traits/winnowing/global-non-global-env-4.rs
 tests/ui/transmutability/enums/uninhabited_optimization.rs
-tests/ui/trivial-bounds/issue-73021-impossible-inline.rs
-tests/ui/trivial-bounds/trivial-bounds-inconsistent.rs
 tests/ui/trivial-bounds/trivial-bounds-object.rs
 tests/ui/try-trait/yeet-for-option.rs
 tests/ui/try-trait/yeet-for-result.rs

@wetneb
Copy link

wetneb commented Jun 4, 2025

Hi @m4rch3n1ng, I have noticed that PRs in this repository are infrequently reviewed, so I have integrated your PR in a fork of this grammar. If you use this grammar in Rust, you can benefit from the improvements in this PR by switching to the tree-sitter-rust-orchard crate on crates.io. Let me know if you need the grammar published in another package repository. I would very much welcome more contributions like this one in the fork, to which I would also be happy to give you write access.

Dear maintainers,
Thank you for your work. It is completely understandable that you have higher priorities in life than integrating external contributions in this repository. If you still wish those contributions to get reviewed, I encourage you to give maintainer rights to more people. The list of PRs and the commit log should help you identify trustworthy contributors who might be interested in helping out. Onboarding new contributors might also be easier if you adopt a governance model for this project. If there is any way I can help, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants