[MLIR][mlir-link] Add appending linkage support #41
+402
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jezurko
force-pushed
the
robert/appending-linkage
branch
from
f0be41a to
93943cc
Compare
Jezurko
force-pushed
the
robert/appending-linkage
branch
from
93943cc to
b50e519
Compare
hbrodin
approved these changes
Jun 5, 2025
Comment on lines
265
to
272
| if (isAppendingLinkage(dstLinkage)) { | ||
| auto &toAppend = append[derived.getSymbol(pair.src)]; | ||
| if (toAppend.empty()) | ||
| toAppend.push_back(pair.dst); | ||
| if (!derived.isDeclaration(pair.src)) { | ||
| toAppend.push_back(pair.src); | ||
| } | ||
| return ConflictResolution::LinkFromSrc; |
There was a problem hiding this comment.
Isn't it a bit unfortunate that we call it getConflictResolution and then add to the list? Maybe there was no other way? Also, the name really suggests the const to be still there...
There was a problem hiding this comment.
I might be able to override resolveConflict and move the list insertion there. I will check
There was a problem hiding this comment.
Yep, should be fixed now
Move insertion to append list to resolveConflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.