Add ServeFile and ServeDir
#45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the future we'll also have `ServeDir` so makes sense for these to live in the same module. Also added a test for `ServeFile`.
So it can be used by the upcoming `ServeFile`
8 tasks
|
@tesaguri Is this something you would be up for reviewing? |
tesaguri
reviewed
Mar 22, 2021
Comment on lines
84
to
93
| if append_index_html_on_directories { | ||
| let is_dir = tokio::fs::metadata(full_path.clone()) | ||
| .await | ||
| .map(|m| m.is_dir()) | ||
| .unwrap_or(false); | ||
|
|
||
| if is_dir { | ||
| full_path.push("index.html"); | ||
| } | ||
| } |
There was a problem hiding this comment.
If the path points to a directory and has no trailing slash, the service should redirect to a URI with a trailing slash.
Suppose that there is ${base}/foo/index.html with a relative URI like <script src="script.js"></script>. When a user agent requests /foo/, the URI script.js resolves to /foo/script.js as expected. But when it requests /foo, script.js resolves to /script.js, which is not the desired behavior.
There was a problem hiding this comment.
Uh thats a good point. Didn't consider that. Fixed in 467dd06
Co-authored-by: Daiki Mizukami <[email protected]>
This way we can change the actual type without breaking changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service that serves a file and guesses the mime type with https://crates.io/crates/mime_guess.