chore: bump thiserror to v2 #3172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourcefrog
added a commit
to sourcefrog/cargo-mutants
that referenced
this pull request
Dec 7, 2024
Bumps all locked dependencies, fixing the following issues: * Building for s390x musl * Building for loongarch64 gnu/musl * [RUSTSEC-2021-0139](https://rustsec.org/advisories/RUSTSEC-2021-0139) on ansi_term (unmaintained) * [RUSTSEC-2024-0320](https://rustsec.org/advisories/RUSTSEC-2024-0320) on yaml-rust (unmaintained) * [RUSTSEC-2024-0404](https://rustsec.org/advisories/RUSTSEC-2024-0404) on anstream (unsound) * Removes some duplicate dependency versions and some unused dependencies - on this I've also opened tokio-rs/tracing#3172 but it'll probably take a long time to get released Remains: * [RUSTSEC-2024-0375](https://rustsec.org/advisories/RUSTSEC-2024-0375) on atty (unmaintained)
0xPoe
approved these changes
Dec 8, 2024
kaffarell
suggested changes
Jan 7, 2025
There was a problem hiding this comment.
Please also update it in the examples crate: examples/Cargo.toml. Quick build works fine but none of the breaking changes (https://github.com/dtolnay/thiserror/releases/tag/2.0.0) should concern us anyways.
paolobarbolini
force-pushed
the
appender-thiserror-2
branch
from
74c6558 to
aab7370
Compare
paolobarbolini
changed the title
|
Any chance of this ever getting merged? |
jplatte
approved these changes
May 27, 2025
jplatte
force-pushed
the
appender-thiserror-2
branch
from
a410bd1 to
3fc3974
Compare
25 tasks
hds
pushed a commit
that referenced
this pull request
May 29, 2025
hds
pushed a commit
that referenced
this pull request
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The ecosystem has upgraded to thiserror v2, so this crate was causing duplicate dependency versions.
Solution
Bump thiserror to v2 - https://github.com/dtolnay/thiserror/releases/tag/2.0.0