Skip to content

MakeWriterExt docs fix #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Conversation

kaffarell
Copy link
Contributor

Fixes #2819

@kaffarell kaffarell requested review from hawkw and a team as code owners December 10, 2023 11:49
@mladedav
Copy link
Contributor

Should this target master instead of v0.1.x? I assume the issue will be there too and backporting should be simple since the context will be the same in the changed file?

@kaffarell kaffarell changed the base branch from v0.1.x to master May 22, 2024 09:22
@kaffarell kaffarell force-pushed the make_writer_docs_fix branch 2 times, most recently from 60eaef8 to e852c4b Compare May 22, 2024 09:41
@kaffarell
Copy link
Contributor Author

Oops, yes. Fixed it!

@jplatte jplatte force-pushed the make_writer_docs_fix branch from fba7540 to 772ca69 Compare May 27, 2025 21:17
@jplatte jplatte enabled auto-merge (squash) May 27, 2025 21:18
@jplatte jplatte merged commit bb9bf11 into tokio-rs:master May 27, 2025
56 checks passed
@hds hds mentioned this pull request May 28, 2025
25 tasks
hds pushed a commit that referenced this pull request May 29, 2025
hds pushed a commit that referenced this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusion when reading doc examples for MakeWriterExt in tracing-subscriber
3 participants