Skip to content

Remove special casing for Redox, as it is now supported by Unix target family #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

jackpot51
Copy link

@jackpot51 jackpot51 commented Apr 3, 2020

This is an alternative to #195 which utilizes libc on Redox. time 0.1 is still used all over the place so it would be great if it could compile on Redox. This change fixes issues with matching both cfg(unix) and cfg(target_os = "redox") by removing the unnecessary additional code for Redox.

@jhpratt
Copy link
Member

jhpratt commented Apr 3, 2020

Time 0.1 is no longer supported, but I will investigate one final round of changes for a 0.1.43 release. This is only because 0.1 has known issues and evidently does not currently build on some systems. Consider this the exception, rather than the rule.

I would like to firmly establish the MSRV, which I know is at least 1.21. There are likely a number of changes that could be made — closed PRs is likely a good starting place. Between COVID-19, college, family, and other commitments, I am very busy, so this certainly won't happen overnight.

Feel free to join Matrix if there is anything specific you'd like to discuss.

@jhpratt jhpratt added C-feature-request Category: a new feature (not already implemented) v0.1 labels Apr 5, 2020
@jhpratt jhpratt added the C-keep-open Category: should not be closed due to inactivity label Apr 7, 2020
@pfmooney
Copy link

Hey @jackpot51,
@jclulow and I are picking up maintenance of the 0.1 branch. Are you at all concerned about Redox users compiling for older versions of rust/libc where the necessary bits aren't yet defined, or is the community keeping pretty up to date on that? If it's the latter, we can get this merged and rolled into the next patch release.

@jackpot51
Copy link
Author

No, there is no concern about that

pfmooney added a commit to pfmooney/time that referenced this pull request Apr 18, 2020
With the merge of time-rs#240, redox support falls under the general unix
platform, but requires a libc which respects that change as well.
@pfmooney pfmooney merged commit 0c24c8c into time-rs:v0.1 Apr 19, 2020
@jackpot51
Copy link
Author

Thanks for merging!

@jhpratt jhpratt removed the C-keep-open Category: should not be closed due to inactivity label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: a new feature (not already implemented)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants