[DNM] *: format diff #1750
Closed
[DNM] *: format diff #1750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
Apr 10, 2017
travis-build/Makefile
Outdated
| mkdir -p ${HOME}/.cargo/bin && tar xzf rustfmt-${RUSTFMT_VERSION}-linux-amd64.tar.gz -C ${HOME}/.cargo/bin --strip-components=1 | ||
| # cargo install --vers =0.6.0 rustfmt || exit 0 | ||
| ${HOME}/.cargo/bin/rustfmt: | ||
| cargo install -f rustfmt |
There was a problem hiding this comment.
do we need to use a special version?
There was a problem hiding this comment.
Only changes are formatted, so I think it's ok to just use the latest version.
|
Do we need to close #1749 now? @overvenus |
|
What about circle CI? For shell script I suggest shellcheck as linter. |
|
PTAL @overvenus @tennix |
|
LGTM |
siddontang
approved these changes
Apr 10, 2017
|
PTAL @overvenus |
Merged
|
It seems that implementation of file lines is naive, let's close it for now and reopen when the feature becomes stable. |
iosmanthus
pushed a commit
to iosmanthus/tikv
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Ray Yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr tries to only format the changed lines rather than anything when make format.
Note that, there is a bug in rustfmt that unrelated comment will be also formatted.