-
Notifications
You must be signed in to change notification settings - Fork 5
Use Storybook to create reusable UI components in isolation #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
749f8e1
Initialize Storybook
anttimaki 6d6b941
Update README with information about Storybook
anttimaki 3b1c34e
Add Thunderstore's background color to Storybook
anttimaki 86d5c54
Add Chakra UI add-on for Storybook
anttimaki c23f39e
Add sample Storybook stories for few simple components
anttimaki 2938095
Add testing library add-on for Storybook
anttimaki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
{ | ||
"sourceType": "unambiguous", | ||
"presets": [ | ||
[ | ||
"@babel/preset-env", | ||
{ | ||
"shippedProposals": true, | ||
"loose": true | ||
} | ||
], | ||
"@babel/preset-typescript" | ||
], | ||
"plugins": [ | ||
"@babel/plugin-transform-shorthand-properties", | ||
"@babel/plugin-transform-block-scoping", | ||
[ | ||
"@babel/plugin-proposal-decorators", | ||
{ | ||
"legacy": true | ||
} | ||
], | ||
[ | ||
"@babel/plugin-proposal-class-properties", | ||
{ | ||
"loose": true | ||
} | ||
], | ||
[ | ||
"@babel/plugin-proposal-private-methods", | ||
{ | ||
"loose": true | ||
} | ||
], | ||
"@babel/plugin-proposal-export-default-from", | ||
"@babel/plugin-syntax-dynamic-import", | ||
[ | ||
"@babel/plugin-proposal-object-rest-spread", | ||
{ | ||
"loose": true, | ||
"useBuiltIns": true | ||
} | ||
], | ||
"@babel/plugin-transform-classes", | ||
"@babel/plugin-transform-arrow-functions", | ||
"@babel/plugin-transform-parameters", | ||
"@babel/plugin-transform-destructuring", | ||
"@babel/plugin-transform-spread", | ||
"@babel/plugin-transform-for-of", | ||
"babel-plugin-macros", | ||
"@babel/plugin-proposal-optional-chaining", | ||
"@babel/plugin-proposal-nullish-coalescing-operator", | ||
[ | ||
"babel-plugin-polyfill-corejs3", | ||
{ | ||
"method": "usage-global", | ||
"absoluteImports": "core-js", | ||
"version": "3.19.1" | ||
} | ||
] | ||
] | ||
} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
/node_modules/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
module.exports = { | ||
"stories": [ | ||
"../stories/**/*.stories.mdx", | ||
{ | ||
"directory": "../stories/components", | ||
"files": "*.stories.*", | ||
"titlePrefix": "@thunderstore/components" | ||
}, | ||
], | ||
"addons": [ | ||
"@storybook/addon-links", | ||
"@storybook/addon-essentials", | ||
"@storybook/addon-interactions", | ||
"@snek-at/storybook-addon-chakra-ui", // Must come after @storybook addons | ||
], | ||
"framework": "@storybook/react", | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
export const parameters = { | ||
actions: { argTypesRegex: "^on[A-Z].*" }, | ||
controls: { | ||
matchers: { | ||
color: /(background|color)$/i, | ||
date: /Date$/, | ||
}, | ||
}, | ||
backgrounds: { | ||
default: "thunderstore", | ||
values: [ | ||
{ name: "thunderstore", value: "#242e48" }, | ||
{ name: "light", value: "#f8f8f8" }, | ||
{ name: "dark", value: "#333" }, | ||
], | ||
}, | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
{ | ||
"name": "@thunderstore/storybook", | ||
"version": "0.0.0", | ||
"private": true, | ||
"main": "index.js", | ||
"license": "MIT", | ||
"devDependencies": { | ||
"@babel/plugin-proposal-class-properties": "^7.16.0", | ||
"@babel/plugin-proposal-decorators": "^7.16.4", | ||
"@babel/plugin-proposal-export-default-from": "^7.16.0", | ||
"@babel/plugin-proposal-nullish-coalescing-operator": "^7.16.0", | ||
"@babel/plugin-proposal-object-rest-spread": "^7.16.0", | ||
"@babel/plugin-proposal-optional-chaining": "^7.16.0", | ||
"@babel/plugin-proposal-private-methods": "^7.16.0", | ||
"@babel/plugin-syntax-dynamic-import": "^7.8.3", | ||
"@babel/plugin-transform-arrow-functions": "^7.16.0", | ||
"@babel/plugin-transform-block-scoping": "^7.16.0", | ||
"@babel/plugin-transform-classes": "^7.16.0", | ||
"@babel/plugin-transform-destructuring": "^7.16.0", | ||
"@babel/plugin-transform-for-of": "^7.16.0", | ||
"@babel/plugin-transform-parameters": "^7.16.3", | ||
"@babel/plugin-transform-shorthand-properties": "^7.16.0", | ||
"@babel/plugin-transform-spread": "^7.16.0", | ||
"@storybook/addon-actions": "^6.4.3", | ||
"@storybook/addon-essentials": "^6.4.3", | ||
"@storybook/addon-interactions": "^6.4.3", | ||
"@storybook/addon-links": "^6.4.3", | ||
"@storybook/jest": "^0.0.5", | ||
"@storybook/react": "^6.4.3", | ||
"@storybook/testing-library": "^0.0.7", | ||
"babel-loader": "^8.2.3", | ||
"babel-plugin-macros": "^3.1.0", | ||
"babel-plugin-polyfill-corejs3": "^0.4.0", | ||
"core-js": "^3.19.1" | ||
}, | ||
"dependencies": { | ||
"@babel/core": "^7.16.0", | ||
"@babel/preset-env": "^7.16.4", | ||
"@babel/preset-typescript": "^7.16.0", | ||
"@chakra-ui/icons": "^1.1.1", | ||
"@chakra-ui/system": "^1.8.2", | ||
"@emotion/react": "^11.7.0", | ||
"@emotion/styled": "^11.6.0", | ||
"@snek-at/storybook-addon-chakra-ui": "^1.0.0-beta.1", | ||
"@thunderstore/components": "^0.1.0", | ||
"react": "^17.0.2", | ||
"react-dom": "^17.0.2", | ||
"webpack": "^4.46.0" | ||
}, | ||
"scripts": { | ||
"storybook": "start-storybook -p 6006", | ||
"build-storybook": "build-storybook" | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,209 @@ | ||
import { Meta } from '@storybook/addon-docs'; | ||
import Code from './assets/code-brackets.svg'; | ||
import Colors from './assets/colors.svg'; | ||
import Comments from './assets/comments.svg'; | ||
import Direction from './assets/direction.svg'; | ||
import Flow from './assets/flow.svg'; | ||
import Plugin from './assets/plugin.svg'; | ||
import Repo from './assets/repo.svg'; | ||
import StackAlt from './assets/stackalt.svg'; | ||
|
||
<Meta title="Example/Introduction" /> | ||
|
||
<style>{` | ||
.subheading { | ||
--mediumdark: '#999999'; | ||
font-weight: 900; | ||
font-size: 13px; | ||
color: #999; | ||
letter-spacing: 6px; | ||
line-height: 24px; | ||
text-transform: uppercase; | ||
margin-bottom: 12px; | ||
margin-top: 40px; | ||
} | ||
|
||
.link-list { | ||
display: grid; | ||
grid-template-columns: 1fr; | ||
grid-template-rows: 1fr 1fr; | ||
row-gap: 10px; | ||
} | ||
|
||
@media (min-width: 620px) { | ||
.link-list { | ||
row-gap: 20px; | ||
column-gap: 20px; | ||
grid-template-columns: 1fr 1fr; | ||
} | ||
} | ||
|
||
@media all and (-ms-high-contrast:none) { | ||
.link-list { | ||
display: -ms-grid; | ||
-ms-grid-columns: 1fr 1fr; | ||
-ms-grid-rows: 1fr 1fr; | ||
} | ||
} | ||
|
||
.link-item { | ||
display: block; | ||
padding: 20px 30px 20px 15px; | ||
border: 1px solid #00000010; | ||
border-radius: 5px; | ||
transition: background 150ms ease-out, border 150ms ease-out, transform 150ms ease-out; | ||
color: #333333; | ||
display: flex; | ||
align-items: flex-start; | ||
} | ||
|
||
.link-item:hover { | ||
border-color: #1EA7FD50; | ||
transform: translate3d(0, -3px, 0); | ||
box-shadow: rgba(0, 0, 0, 0.08) 0 3px 10px 0; | ||
} | ||
|
||
.link-item:active { | ||
border-color: #1EA7FD; | ||
transform: translate3d(0, 0, 0); | ||
} | ||
|
||
.link-item strong { | ||
font-weight: 700; | ||
display: block; | ||
margin-bottom: 2px; | ||
} | ||
|
||
.link-item img { | ||
height: 40px; | ||
width: 40px; | ||
margin-right: 15px; | ||
flex: none; | ||
} | ||
|
||
.link-item span { | ||
font-size: 14px; | ||
line-height: 20px; | ||
} | ||
|
||
.tip { | ||
display: inline-block; | ||
border-radius: 1em; | ||
font-size: 11px; | ||
line-height: 12px; | ||
font-weight: 700; | ||
background: #E7FDD8; | ||
color: #66BF3C; | ||
padding: 4px 12px; | ||
margin-right: 10px; | ||
vertical-align: top; | ||
} | ||
|
||
.tip-wrapper { | ||
font-size: 13px; | ||
line-height: 20px; | ||
margin-top: 40px; | ||
margin-bottom: 40px; | ||
} | ||
|
||
.tip-wrapper code { | ||
font-size: 12px; | ||
display: inline-block; | ||
} | ||
`}</style> | ||
|
||
# Welcome to Storybook | ||
|
||
Storybook helps you build UI components in isolation from your app's business logic, data, and context. | ||
That makes it easy to develop hard-to-reach states. Save these UI states as **stories** to revisit during development, testing, or QA. | ||
|
||
Browse example stories now by navigating to them in the sidebar. | ||
View their code in the `src/stories` directory to learn how they work. | ||
We recommend building UIs with a [**component-driven**](https://componentdriven.org) process starting with atomic components and ending with pages. | ||
|
||
<div className="subheading">Configure</div> | ||
|
||
<div className="link-list"> | ||
<a | ||
className="link-item" | ||
href="https://storybook.js.org/docs/react/addons/addon-types" | ||
target="_blank" | ||
> | ||
<img src={Plugin} alt="plugin" /> | ||
<span> | ||
<strong>Presets for popular tools</strong> | ||
Easy setup for TypeScript, SCSS and more. | ||
</span> | ||
</a> | ||
<a | ||
className="link-item" | ||
href="https://storybook.js.org/docs/react/configure/webpack" | ||
target="_blank" | ||
> | ||
<img src={StackAlt} alt="Build" /> | ||
<span> | ||
<strong>Build configuration</strong> | ||
How to customize webpack and Babel | ||
</span> | ||
</a> | ||
<a | ||
className="link-item" | ||
href="https://storybook.js.org/docs/react/configure/styling-and-css" | ||
target="_blank" | ||
> | ||
<img src={Colors} alt="colors" /> | ||
<span> | ||
<strong>Styling</strong> | ||
How to load and configure CSS libraries | ||
</span> | ||
</a> | ||
<a | ||
className="link-item" | ||
href="https://storybook.js.org/docs/react/get-started/setup#configure-storybook-for-your-stack" | ||
target="_blank" | ||
> | ||
<img src={Flow} alt="flow" /> | ||
<span> | ||
<strong>Data</strong> | ||
Providers and mocking for data libraries | ||
</span> | ||
</a> | ||
</div> | ||
|
||
<div className="subheading">Learn</div> | ||
|
||
<div className="link-list"> | ||
<a className="link-item" href="https://storybook.js.org/docs" target="_blank"> | ||
<img src={Repo} alt="repo" /> | ||
<span> | ||
<strong>Storybook documentation</strong> | ||
Configure, customize, and extend | ||
</span> | ||
</a> | ||
<a className="link-item" href="https://storybook.js.org/tutorials/" target="_blank"> | ||
<img src={Direction} alt="direction" /> | ||
<span> | ||
<strong>In-depth guides</strong> | ||
Best practices from leading teams | ||
</span> | ||
</a> | ||
<a className="link-item" href="https://github.com/storybookjs/storybook" target="_blank"> | ||
<img src={Code} alt="code" /> | ||
<span> | ||
<strong>GitHub project</strong> | ||
View the source and add issues | ||
</span> | ||
</a> | ||
<a className="link-item" href="https://discord.gg/storybook" target="_blank"> | ||
<img src={Comments} alt="comments" /> | ||
<span> | ||
<strong>Discord chat</strong> | ||
Chat with maintainers and the community | ||
</span> | ||
</a> | ||
</div> | ||
|
||
<div className="tip-wrapper"> | ||
<span className="tip">Tip</span>Edit the Markdown in{' '} | ||
<code>src/stories/Introduction.stories.mdx</code> | ||
</div> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-commit not handling missing newlines in this repo? Should we perhaps add pre-commit or something similar (in another PR)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well there is this long-forgotten PR: #32 .
There's also seems to be a pre-commit config in the repo, but I've not set it up yet. Should we use pre-commit as we do in our other repos and ignore that old PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that sounds like a good idea