Skip to content

[wallet, react] Add Coin98 Wallet #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 20, 2023
Merged

[wallet, react] Add Coin98 Wallet #1921

merged 11 commits into from
Nov 20, 2023

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 10, 2023

Problem solved

Give it a try: https://coin98-wallet.vercel.app/

  • Browser extension
  • Deeplink for mobile

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

Copy link

changeset-bot bot commented Nov 10, 2023

🦋 Changeset detected

Latest commit: be6c903

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@thirdweb-dev/react-core Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/react Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/auth Patch
thirdweb Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kien-ngo
Copy link
Contributor Author

/release-pr

@kien-ngo
Copy link
Contributor Author

/release-pr

@kien-ngo
Copy link
Contributor Author

/release-pr

@kien-ngo
Copy link
Contributor Author

kien-ngo commented Nov 10, 2023

@ MananTank their deeplink doesn't seem to work, I have reached out to their Discord
https://docs.coin98.com/developer-guide/deeplink

Also the deeplink has a chainId parameter. Checking with them if it's optional, otherwise will need to get the chainId before calling the URL

Other than that, it's working

@kien-ngo
Copy link
Contributor Author

/release-pr

@kien-ngo
Copy link
Contributor Author

/release-pr

@kien-ngo
Copy link
Contributor Author

@MananTank this PR is ready to be reviewed.
I deployed a website for you too ^: https://coin98-wallet.vercel.app/

@kien-ngo kien-ngo marked this pull request as ready for review November 13, 2023 02:32
@kien-ngo kien-ngo requested a review from a team as a code owner November 13, 2023 02:32
@kien-ngo kien-ngo requested review from a team and MananTank November 13, 2023 02:32
@kien-ngo kien-ngo self-assigned this Nov 13, 2023
@MananTank
Copy link
Member

MananTank commented Nov 20, 2023

LGTM, Thanks @kien-ngo!

@MananTank MananTank enabled auto-merge November 20, 2023 16:21
@MananTank MananTank added this pull request to the merge queue Nov 20, 2023
Merged via the queue into main with commit 1094a03 Nov 20, 2023
@MananTank MananTank deleted the kien/c98 branch November 20, 2023 16:31
@github-actions github-actions bot mentioned this pull request Nov 20, 2023
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
* Update Sub-header.tsx

Signed-off-by: cattyjones <[email protected]>

* Update Sub-Header

Signed-off-by: cattyjones <[email protected]>

* Fix

* Quick comma fix

Signed-off-by: Juan Leal <[email protected]>

---------

Signed-off-by: cattyjones <[email protected]>
Signed-off-by: Juan Leal <[email protected]>
Co-authored-by: Nacho Iacovino <[email protected]>
Co-authored-by: Juan Leal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants