Skip to content

[RN] i18n more strings and fix fontFamily #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Oct 20, 2023
Merged
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,11 @@ import { WalletIcon } from "../base/WalletIcon";
import WalletConnectIcon from "../../assets/wallet-connect";
import QrCodeIcon from "../../assets/qr-code";
import { QRCodeScan } from "./QRCodeScan";
import { useLocale } from "../../providers/ui-context-provider";

const ConnectAppField = () => {
const theme = useTheme();
const l = useLocale();
const [showWCInput, setShowWCInput] = useState(false);
const [wcUri, setWCUri] = useState<string | undefined>();
const [appMeta, setAppMeta] = useState<{ name: string; iconUrl: string }>();
Expand Down Expand Up @@ -132,7 +134,7 @@ const ConnectAppField = () => {
numberOfLines: 1,
style: {
color: theme.colors.textPrimary,
fontFamily: theme.textVariants.defaults.fontFamily,
// fontFamily: theme.textVariants.defaults.fontFamily,
},
}}
containerProps={{
Expand Down Expand Up @@ -181,7 +183,7 @@ const ConnectAppField = () => {
)}
<View style={styles.exportWalletInfo}>
<Text variant="bodySmall" numberOfLines={1}>
{appMeta ? appMeta.name : "Connect app"}
{appMeta ? appMeta.name : l.common.connect_app}
</Text>
</View>
</>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ export function ChooseWallet({
>
<Box height={1} flex={1} backgroundColor="border" />
<Text variant="subHeader" textAlign="center" marginHorizontal="xxs">
OR
{l.common.or}
</Text>
<Box height={1} flex={1} backgroundColor="border" />
</Box>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ export const LocalWalletImportModal = ({
onChangeText: onPrivateKeyEntered,
style: {
color: theme.colors.textPrimary,
fontFamily: theme.textVariants.defaults.fontFamily,
// fontFamily: theme.textVariants.defaults.fontFamily,
},
}}
containerProps={{ pl: "xxs" }}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/src/evm/components/PasswordInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const PasswordInput = ({
style={{
...styles.textInput,
color: theme.colors.textPrimary,
fontFamily: theme.textVariants.defaults.fontFamily,
// fontFamily: theme.textVariants.defaults.fontFamily,
}}
secureTextEntry={!showPassword}
textContentType="none"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ const SendFundsForm = ({
onChangeText={setReceiverAddress}
style={{
color: theme.colors.textPrimary,
fontFamily: theme.textVariants.defaults.fontFamily,
// fontFamily: theme.textVariants.defaults.fontFamily,
textAlign: "left",
flex: 1,
height: 40,
Expand Down Expand Up @@ -323,7 +323,7 @@ const SendFundsForm = ({
clearTextOnFocus={false}
style={{
color: theme.colors.textPrimary,
fontFamily: theme.textVariants.defaults.fontFamily,
// fontFamily: theme.textVariants.defaults.fontFamily,
textAlign: "left",
flex: 1,
height: 40,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export function TokenSelector(props: {
onChangeText={setInput}
style={{
color: theme.colors.textPrimary,
fontFamily: theme.textVariants.defaults.fontFamily,
// fontFamily: theme.textVariants.defaults.fontFamily,
textAlign: "left",
flex: 1,
height: 40,
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/src/evm/i18n/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,14 @@ export const _en = {
request_new_code: "Request new code",
sign_in: "Sign In",
sign_in_google: "Sign in with Google",
enter_your_email: "Enter your email address",
},
wallet_connect: {
no_results_found: "No results found",
search_wallets: "Search Wallets",
},
common: {
connect_app: "Connect app",
unknown_network: "Unknown Network",
fetching: "Fetching...",
password: "Password",
Expand Down
16 changes: 7 additions & 9 deletions packages/react-native/src/evm/styles/textVariants.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
import { Platform } from "react-native";

export const textVariants = {
defaults: {
fontFamily: Platform.OS === "ios" ? "san Francisco" : "Roboto",
fontSize: 24,
fontWeight: "700",
lineHeight: 32,
color: "textPrimary",
},
// defaults: {
// fontFamily: "ShopifySans", //Platform.OS === "ios" ? "San Francisco" : "Roboto",
// fontSize: 24,
// fontWeight: "700",
// lineHeight: 32,
// color: "textPrimary",
// },
header: {
fontSize: 24,
fontWeight: "600",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export const EmailSelectionUI: React.FC<
textAlign="center"
marginHorizontal="xxs"
>
OR
{l.common.or}
</Text>
<Box height={1} flex={1} backgroundColor="border" />
</Box>
Expand All @@ -131,13 +131,13 @@ export const EmailSelectionUI: React.FC<
<>
<TextInput
textInputProps={{
placeholder: "Enter your email address",
placeholder: l.embedded_wallet.enter_your_email,
placeholderTextColor: theme.colors.textSecondary,
onChangeText: setEmailInput,
style: {
fontSize: 14,
color: theme.colors.textPrimary,
fontFamily: theme.textVariants.defaults.fontFamily,
// fontFamily: theme.textVariants.defaults.fontFamily,
lineHeight: 16,
padding: 0,
flex: 1,
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/src/evm/wallets/wallets/magic-link.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,15 @@ const MagicSelectionUI: React.FC<SelectUIProps<MagicLink>> = (props) => {
<Box paddingHorizontal="xl" mt="lg">
<TextInput
textInputProps={{
placeholder: "Enter your email address",
placeholder: l.embedded_wallet.enter_your_email,
placeholderTextColor: theme.colors.textSecondary,
onChangeText: (text: string) => {
setEmail(text);
},
style: {
fontSize: 14,
color: theme.colors.textPrimary,
fontFamily: theme.textVariants.defaults.fontFamily,
// fontFamily: theme.textVariants.defaults.fontFamily,
lineHeight: 16,
padding: 0,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export function WalletConnectUI({
style={{
...styles.textInput,
color: theme.colors.textSecondary,
fontFamily: theme.textVariants.defaults.fontFamily,
// fontFamily: theme.textVariants.defaults.fontFamily,
}}
/>
</Box>
Expand Down