Skip to content

[RN] Improve UI and theming #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 19, 2023
Merged

[RN] Improve UI and theming #1803

merged 3 commits into from
Oct 19, 2023

Conversation

iketw
Copy link
Contributor

@iketw iketw commented Oct 19, 2023

Problem solved

Fixed some padding/margins and allowed for more customizations in the theme prop

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

@iketw iketw requested a review from a team October 19, 2023 14:55
@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

🦋 Changeset detected

Latest commit: b89d33e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@thirdweb-dev/react-native Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iketw iketw enabled auto-merge October 19, 2023 14:56
// @ts-ignore
deepMerge(target[key], source[key]);
} else {
target[key] = source[key] as any;

Check warning

Code scanning / CodeQL

Prototype-polluting function

Properties are copied from [source](1) to [target](2) without guarding against prototype pollution.
@iketw iketw added this pull request to the merge queue Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
packages/sdk/src/evm/common/index.ts 100.00% <100.00%> (ø)
...sdk/src/evm/common/plugin/getCompositePluginABI.ts 75.00% <100.00%> (ø)
.../contracts/prebuilt-implementations/marketplace.ts 73.75% <100.00%> (ø)
...src/evm/contracts/prebuilt-implementations/pack.ts 67.66% <100.00%> (-0.39%) ⬇️
...rc/evm/contracts/prebuilt-implementations/split.ts 86.17% <100.00%> (-0.70%) ⬇️
packages/sdk/src/evm/core/sdk.ts 70.50% <100.00%> (ø)
...ckages/sdk/src/evm/functions/getContractFromAbi.ts 75.00% <100.00%> (ø)
packages/sdk/src/evm/contracts/index.ts 67.77% <66.66%> (ø)
...vm/contracts/prebuilt-implementations/multiwrap.ts 84.84% <50.00%> (-0.31%) ⬇️
...src/evm/contracts/prebuilt-implementations/vote.ts 71.42% <85.71%> (+0.14%) ⬆️

📢 Thoughts on this report? Let us know!.

Merged via the queue into main with commit a63f5dc Oct 19, 2023
@iketw iketw deleted the ike/customize branch October 19, 2023 15:12
@github-actions github-actions bot mentioned this pull request Oct 19, 2023
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant