-
Notifications
You must be signed in to change notification settings - Fork 412
feat: #9: Normalized whitespace using dom-testing-library #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gnapse
merged 6 commits into
testing-library:master
from
smacpherson64:pr/to-have-text-content-whitespace
Oct 2, 2018
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a6f7e59
#9: Normalized whitespace using dom-testing-library
smacpherson64 12b467c
#9: Fixed format style for better viewing
smacpherson64 23440b1
Made normalizeSpaces to be optional on toHaveTextContent
smacpherson64 cb892c0
#9: Removed unused node from matches function
smacpherson64 da2fd51
#9: Changed optional to be normalizeWhitespace, making it on by default
smacpherson64 a96b794
Merge branch 'master' into pr/to-have-text-content-whitespace
smacpherson64 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,48 @@ | ||
import {render} from './helpers/test-utils' | ||
|
||
test('.toHaveTextContent', () => { | ||
const {queryByTestId} = render(`<span data-testid="count-value">2</span>`) | ||
|
||
expect(queryByTestId('count-value')).toHaveTextContent('2') | ||
expect(queryByTestId('count-value')).toHaveTextContent(2) | ||
expect(queryByTestId('count-value')).toHaveTextContent(/2/) | ||
expect(queryByTestId('count-value')).not.toHaveTextContent('21') | ||
expect(() => | ||
expect(queryByTestId('count-value2')).toHaveTextContent('2'), | ||
).toThrowError() | ||
|
||
expect(() => | ||
expect(queryByTestId('count-value')).toHaveTextContent('3'), | ||
).toThrowError() | ||
expect(() => | ||
expect(queryByTestId('count-value')).not.toHaveTextContent('2'), | ||
).toThrowError() | ||
describe('.toHaveTextContent', () => { | ||
test('handles positive test cases', () => { | ||
const {queryByTestId} = render(`<span data-testid="count-value">2</span>`) | ||
|
||
expect(queryByTestId('count-value')).toHaveTextContent('2') | ||
expect(queryByTestId('count-value')).toHaveTextContent(2) | ||
expect(queryByTestId('count-value')).toHaveTextContent(/2/) | ||
expect(queryByTestId('count-value')).not.toHaveTextContent('21') | ||
}) | ||
|
||
test('handles negative test cases', () => { | ||
const {queryByTestId} = render(`<span data-testid="count-value">2</span>`) | ||
|
||
expect(() => | ||
expect(queryByTestId('count-value2')).toHaveTextContent('2'), | ||
).toThrowError() | ||
|
||
expect(() => | ||
expect(queryByTestId('count-value')).toHaveTextContent('3'), | ||
).toThrowError() | ||
expect(() => | ||
expect(queryByTestId('count-value')).not.toHaveTextContent('2'), | ||
).toThrowError() | ||
}) | ||
|
||
test('normalizes whitespace by default', () => { | ||
const {container} = render(` | ||
<span> | ||
Step | ||
1 | ||
of | ||
4 | ||
</span> | ||
`) | ||
|
||
expect(container.querySelector('span')).toHaveTextContent('Step 1 of 4') | ||
}) | ||
|
||
test('allows whitespace normalization to be turned off', () => { | ||
const {container} = render(`<span> Step 1 of 4</span>`) | ||
|
||
expect(container.querySelector('span')).toHaveTextContent(' Step 1 of 4', { | ||
normalizeWhitespace: false, | ||
}) | ||
}) | ||
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that you started separating the test cases. It was becoming hard to read. 👏 👏 👏