You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
problem D: no-wait-for-multiple-assertions should display the error on each assertion other than the first one instead of a single error on waitFor
problem E: no-wait-for-side-effects should display the error on each side effect instead of a single error on waitFor
problem F: ESLint peerDependency seems set incorrectly this is actually fine, it seems a warning due to installing it through resolutions and ESLint being a sub-dependency of react-scripts
The text was updated successfully, but these errors were encountered:
👏 nice work here!
Question, what's the expected message in the prefer-find-by error? Do you expect the full prefer screen.findByRole('button', { name: /submit/i }) ?
@gndelia the error should say just "use findByRole instead of waitFor + getByRole, so it's something simple. Otherwise we pollute the output with a lot of code.
The first round of issues I found while testing v4 beta:
await-async-utils
doesn't report the right node nameprefer-find-by
is reporting an incorrect messageno-await-sync-query
reports an error when a parent is awaited (related to [v4][no-await-sync-query] False positives on appearance/disappearance examples #304 )no-wait-for-multiple-assertions
should display the error on each assertion other than the first one instead of a single error onwaitFor
no-wait-for-side-effects
should display the error on each side effect instead of a single error onwaitFor
problem F: ESLintthis is actually fine, it seems a warning due to installing it throughpeerDependency
seems set incorrectlyresolutions
and ESLint being a sub-dependency ofreact-scripts
The text was updated successfully, but these errors were encountered: