Skip to content

First round of v4 beta issues #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Belco90 opened this issue Mar 29, 2021 · 4 comments
Closed

First round of v4 beta issues #307

Belco90 opened this issue Mar 29, 2021 · 4 comments
Assignees
Milestone

Comments

@Belco90
Copy link
Member

Belco90 commented Mar 29, 2021

The first round of issues I found while testing v4 beta:

  • problem A: await-async-utils doesn't report the right node name
    CleanShot 2021-03-28 at 20 54 18@2x
  • problem B: prefer-find-by is reporting an incorrect message
    CleanShot 2021-03-28 at 21 24 41@2x
  • problem C: no-await-sync-query reports an error when a parent is awaited (related to [v4][no-await-sync-query] False positives on appearance/disappearance examples #304 )
    CleanShot 2021-03-28 at 20 55 14@2x
  • problem D: no-wait-for-multiple-assertions should display the error on each assertion other than the first one instead of a single error on waitFor
  • problem E: no-wait-for-side-effects should display the error on each side effect instead of a single error on waitFor
  • problem F: ESLint peerDependency seems set incorrectly this is actually fine, it seems a warning due to installing it through resolutions and ESLint being a sub-dependency of react-scripts
    CleanShot 2021-03-29 at 21 54 25@2x
@Belco90 Belco90 self-assigned this Mar 29, 2021
@gndelia
Copy link
Collaborator

gndelia commented Apr 1, 2021

👏 nice work here!
Question, what's the expected message in the prefer-find-by error? Do you expect the full prefer screen.findByRole('button', { name: /submit/i }) ?

@Belco90
Copy link
Member Author

Belco90 commented Apr 2, 2021

@gndelia the error should say just "use findByRole instead of waitFor + getByRole, so it's something simple. Otherwise we pollute the output with a lot of code.

Belco90 added a commit that referenced this issue Apr 3, 2021
@github-actions
Copy link

github-actions bot commented Apr 3, 2021

🎉 This issue has been resolved in version 4.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelDeBoey MichaelDeBoey added this to the v4 milestone Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants