-
Notifications
You must be signed in to change notification settings - Fork 2
Fix problem if topology isn't applied correctly #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
src/main/java/org/testcontainers/containers/exceptions/CartridgeContainerException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
package org.testcontainers.containers.exceptions; | ||
|
||
/** | ||
* Base class for Cartridge runtime exceptions | ||
* | ||
* @author Artyom Dubinin | ||
*/ | ||
public abstract class CartridgeContainerException extends TarantoolContainerException { | ||
} |
14 changes: 14 additions & 0 deletions
14
src/main/java/org/testcontainers/containers/exceptions/CartridgeTopologyException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package org.testcontainers.containers.exceptions; | ||
|
||
public class CartridgeTopologyException extends TarantoolContainerException { | ||
|
||
static final String errorMsg = "Failed to change the app topology"; | ||
|
||
public CartridgeTopologyException(String message) { | ||
super(message); | ||
} | ||
|
||
public CartridgeTopologyException(Throwable cause) { | ||
super(errorMsg, cause); | ||
} | ||
} |
24 changes: 24 additions & 0 deletions
24
src/main/java/org/testcontainers/containers/exceptions/TarantoolContainerException.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
package org.testcontainers.containers.exceptions; | ||
|
||
/** | ||
* Base class for Tarantool runtime exceptions | ||
* | ||
* @author Artyom Dubinin | ||
*/ | ||
public abstract class TarantoolContainerException extends RuntimeException { | ||
public TarantoolContainerException(String message) { | ||
super(message); | ||
} | ||
|
||
public TarantoolContainerException() { | ||
super(); | ||
} | ||
|
||
public TarantoolContainerException(Throwable cause) { | ||
super(cause); | ||
} | ||
|
||
public TarantoolContainerException(String message, Throwable cause) { | ||
super(message, cause); | ||
} | ||
} |
4 changes: 4 additions & 0 deletions
4
src/main/java/org/testcontainers/containers/exceptions/package-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
/** | ||
* Exception classes for internal client errors to be translated to user | ||
*/ | ||
package org.testcontainers.containers.exceptions; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
cartridge = require('cartridge') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. q: what is incorrect in this topology? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's no server on 3303 port. I added comment in topology |
||
replicasets = { { | ||
alias = 'app-router', | ||
roles = { 'vshard-router', 'app.roles.custom', 'app.roles.api_router' }, | ||
join_servers = { { uri = 'localhost:3301' } } | ||
}, { | ||
alias = 's1-storage', | ||
roles = { 'vshard-storage', 'app.roles.api_storage' }, | ||
join_servers = { { uri = 'localhost:3302' } } | ||
}, | ||
{ | ||
alias = 's2-storage', | ||
roles = { 'vshard-storage', 'app.roles.api_storage' }, | ||
join_servers = { { uri = 'localhost:3303' } } -- non-existent server | ||
} } | ||
return cartridge.admin_edit_topology({ replicasets = replicasets }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC Vova changed this line because we had some problems with windows (?) or something. Did you look at the history of this change? Is it safe to use binding here? (I know, it's the default preferred variant, but there was some problem)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to see why it had been changed #46. I asked @dkasimovskiy to try to run tests(he has windows + wsl) but he didn't get what I want and merged PR 🤷♂️
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akudiyar we will test how it's working with windows. You can check other PRs in testcontainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the latest WSL2 it works fine.