Skip to content

It's not possible to disable directory binding even if it's not specified #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vrogach2020 opened this issue Nov 11, 2021 · 0 comments · Fixed by #29
Closed

It's not possible to disable directory binding even if it's not specified #24

vrogach2020 opened this issue Nov 11, 2021 · 0 comments · Fixed by #29
Assignees
@vrogach2020
Labels
bug Something isn't working customer

Comments

@vrogach2020
Copy link
Contributor

Not if I want to use withCopyFileToContainer() instead of withDirectoryBinding() the repository root is bound anyway.
This happens because by default directory binding is an empty string in code and it is always bound without any check conditions.
@vrogach2020 vrogach2020 added bug Something isn't working customer labels Nov 11, 2021
@vrogach2020 vrogach2020 self-assigned this Nov 11, 2021
vrogach2020 pushed a commit that referenced this issue Nov 11, 2021
Closes #24, closes #25. Add option to bind container to fixed host ports
649852c
@vrogach2020 vrogach2020 mentioned this issue Nov 11, 2021
Merged
vrogach2020 added a commit that referenced this issue Nov 11, 2021
@vrogach2020
Fix problems with ports and directory bindings. (#29)
0bcbdeb 
* Closes #24, closes #25. Add option to bind container to fixed host ports
* Add tests for dynamic cartridge container with different options
* Refactor cartridge container creation
@vrogach2020 vrogach2020 mentioned this issue Nov 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrogach2020 vrogach2020

Labels
bug Something isn't working customer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix problems with ports and directory bindings. tarantool/testcontainers-java-tarantool
1 participant
@vrogach2020