Add deploy to our RPM/DEB S3 repositories #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
reviewed
Nov 29, 2022
Totktonada
reviewed
Nov 29, 2022
It is better to use bundled small and msgpuck, because not all repositories have these packages. Part of #65 fixup: embedded small and msgpuck
Starting with fedora 33, the cmake build strategy has been changed to "out-of-source builds" by default (see [1]). Let's add support for the new behavior. [1] https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds Part of #65
LeonidVas
force-pushed
the
lvasiliev/gh-65-CD-to-S3
branch
from
d8ca31d to
bf38f5a
Compare
Totktonada
reviewed
Nov 30, 2022
.github/workflows/packaging.yml
Outdated
Comment on lines
73
to
75
| # We don't want to try to print secrets to the log, but we want | ||
| # to print a "curl" command to see what's going on. | ||
| CURL_CMD_ECHO="curl -LfsS \ |
There was a problem hiding this comment.
Nit: The comment is indented in a surprising way.
There was a problem hiding this comment.
If I indent with CURL..., Sublime does not decorates it as a comment. I decided not to argue Sublime.
I will read the documentation tomorrow.
Totktonada
approved these changes
Nov 30, 2022
LeonidVas
force-pushed
the
lvasiliev/gh-65-CD-to-S3
branch
from
5162a50 to
cfd8069
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.