api: add Connection.CloseGraceful() and ConnectionPool.CloseGraceful() #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We forgot to update a comment about the state. Part of #257
CloseGraceful closes Connection gracefully. Unlike Connection.Close() it waits for all requests to complete. Part of #257
CloseGraceful closes ConnectionPool gracefully. Unlike ConnectionPool.Close() it waits for all requests to complete. Closes #257
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-257-graceful-close
branch
from
d4b7b25 to
2be2bdb
Compare
better0fdead
approved these changes
May 29, 2023
GRISHNOV
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloseGraceful closes Connection gracefully. Unlike Connection.Close() it waits for all requests to complete.
CloseGraceful closes ConnectionPool gracefully. Unlike ConnectionPool.Close() it waits for all requests to complete.
Changes to the connection pool may seem too global, but it will simplify #290 .
I didn't forget about (remove if it is not applicable):
Related issues:
Closes #257