Skip to content

Broken GoDoc in comment for Decimal.UnmarshalMsgpack #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ligurio opened this issue Aug 4, 2022 · 0 comments · Fixed by #202
Closed

Broken GoDoc in comment for Decimal.UnmarshalMsgpack #201

ligurio opened this issue Aug 4, 2022 · 0 comments · Fixed by #202
Labels
documentation Improvements or additions to documentation

Comments

@ligurio
Copy link
Member

ligurio commented Aug 4, 2022

See https://pkg.go.dev/github.com/tarantool/[email protected]/decimal#Decimal.UnmarshalMsgpack
image
oleg-jukovec added a commit that referenced this issue Aug 4, 2022
@oleg-jukovec
decimal: fix godoc
90bebb4 
The patch fixes markdown of Decimal.UnmarshalMsgpack method in godoc. It
also makes the package description less confusing, removes duplication.

Closes #201
oleg-jukovec added a commit that referenced this issue Aug 4, 2022
@oleg-jukovec
decimal: fix godoc
6e21eed 
The patch fixes markdown of Decimal.UnmarshalMsgpack method in godoc. It
also makes the package description less confusing, removes duplication.

Closes #201
oleg-jukovec added a commit that referenced this issue Aug 4, 2022
@oleg-jukovec
decimal: fix godoc
520bb71 
The patch fixes markdown of Decimal.UnmarshalMsgpack method in godoc. It
also makes the package description less confusing, removes duplication.

Closes #201
@oleg-jukovec oleg-jukovec mentioned this issue Aug 4, 2022
Merged
1 task
oleg-jukovec added a commit that referenced this issue Aug 8, 2022
@oleg-jukovec
decimal: fix godoc
e9f45ab 
The patch hides the implementation details of the Decimal type from
GoDoc. It provides comments for Decimal.MarshalMsgpack and
Decimal.UnmarshalMsgpack.

Closes #201
oleg-jukovec added a commit that referenced this issue Aug 11, 2022
@oleg-jukovec
decimal: fix godoc
ff497a2 
The patch hides the implementation details of the Decimal type from
GoDoc. It provides comments for Decimal.MarshalMsgpack and
Decimal.UnmarshalMsgpack.

Closes #201
oleg-jukovec added a commit that referenced this issue Aug 11, 2022
@oleg-jukovec
decimal: fix godoc
ba1aa4b 
The patch hides the implementation details of the Decimal type from
GoDoc. It provides comments for Decimal.MarshalMsgpack and
Decimal.UnmarshalMsgpack.

Closes #201
@kyukhin kyukhin added documentation Improvements or additions to documentation teamE labels Aug 12, 2022
oleg-jukovec added a commit that referenced this issue Aug 17, 2022
@oleg-jukovec
doc: fix markdown for decimal package
1283d64 
The patch hides the implementation details of the Decimal type from
GoDoc. It provides comments for Decimal.MarshalMsgpack and
Decimal.UnmarshalMsgpack.

Closes #201
oleg-jukovec added a commit that referenced this issue Aug 17, 2022
@oleg-jukovec
doc: fix markdown for decimal package
a820c8d 
The patch hides the implementation details of the Decimal type from
documentation. It provides comments for Decimal.MarshalMsgpack and
Decimal.UnmarshalMsgpack.

Closes #201
oleg-jukovec added a commit that referenced this issue Aug 17, 2022
@oleg-jukovec
doc: fix markdown for the decimal package
89896c3 
The patch hides the implementation details of the Decimal type from
documentation. It provides comments for Decimal.MarshalMsgpack and
Decimal.UnmarshalMsgpack.

Closes #201
oleg-jukovec added a commit that referenced this issue Aug 17, 2022
@oleg-jukovec
Release 1.8.0
796db57 
Overview

    The minor release with time zones and interval support for
    datetime.

    Also now you can use go-tarantool with `msgpack.v5`. To do this,
    add `go_tarantool_msgpack_v5` to your build tags:

    $ go build -tags=go_tarantool_msgpack_v5 .

Breaking changes

    There are no breaking changes in the release.

New features

    Optional msgpack.v5 usage (#124).

    TZ support for datetime (#163).

    Interval support for datetime (#165).

Bugfixes

    Markdown of documentation for the decimal subpackage (#201).
@oleg-jukovec oleg-jukovec mentioned this issue Aug 17, 2022
Merged
oleg-jukovec added a commit that referenced this issue Aug 17, 2022
@oleg-jukovec
doc: fix markdown for the decimal subpackage
9ee249f 
The patch hides the implementation details of the Decimal type from
documentation. It provides comments for Decimal.MarshalMsgpack and
Decimal.UnmarshalMsgpack.

Closes #201
oleg-jukovec added a commit that referenced this issue Aug 17, 2022
@oleg-jukovec
doc: fix markdown for the decimal subpackage
b9ddb95 
The patch hides the implementation details of the Decimal type from
documentation. It provides comments for Decimal.MarshalMsgpack and
Decimal.UnmarshalMsgpack.

Closes #201
oleg-jukovec added a commit that referenced this issue Aug 17, 2022
@oleg-jukovec
doc: fix markdown for the decimal subpackage
e948683 
The patch hides the implementation details of the Decimal type from
documentation. It provides comments for Decimal.MarshalMsgpack and
Decimal.UnmarshalMsgpack.

Closes #201
oleg-jukovec added a commit that referenced this issue Aug 17, 2022
@oleg-jukovec
Release 1.8.0
48d736c 
Overview

    The minor release with time zones and interval support for
    datetime.

    Also now you can use go-tarantool with `msgpack.v5`. To do this,
    add `go_tarantool_msgpack_v5` to your build tags:

    $ go build -tags=go_tarantool_msgpack_v5 .

Breaking changes

    There are no breaking changes in the release.

New features

    Optional msgpack.v5 usage (#124).

    TZ support for datetime (#163).

    Interval support for datetime (#165).

Bugfixes

    Markdown of documentation for the decimal subpackage (#201).
oleg-jukovec added a commit that referenced this issue Aug 17, 2022
@oleg-jukovec
Release 1.8.0
a8e0344 
Overview

    The minor release with time zones and interval support for
    datetime.

    Also now you can use go-tarantool with `msgpack.v5`. To do this,
    add `go_tarantool_msgpack_v5` to your build tags:

    $ go build -tags=go_tarantool_msgpack_v5 .

Breaking changes

    There are no breaking changes in the release.

New features

    Optional msgpack.v5 usage (#124).

    TZ support for datetime (#163).

    Interval support for datetime (#165).

Bugfixes

    Markdown of documentation for the decimal subpackage (#201).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: fix markdown for the decimal package tarantool/go-tarantool
2 participants
@ligurio @kyukhin