Skip to content

Describe box.ctl.demote() function #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Describe box.ctl.demote() function #3162

merged 3 commits into from
Oct 6, 2022

Conversation

xuniq
Copy link
Contributor

@xuniq xuniq commented Sep 23, 2022

Resolves #2278

@xuniq xuniq force-pushed the 2278-box-ctl-demote branch from 7cb53f9 to 648df62 Compare September 29, 2022 10:26
@xuniq xuniq marked this pull request as ready for review September 29, 2022 10:27
@xuniq xuniq force-pushed the 2278-box-ctl-demote branch from 648df62 to ced74d9 Compare October 3, 2022 10:35
@xuniq xuniq requested a review from sergepetrenko October 3, 2022 10:38
@xuniq xuniq requested a review from sergepetrenko October 3, 2022 16:22
Copy link
Contributor

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

One more comment.

@xuniq xuniq requested review from sergepetrenko and p7nov October 4, 2022 09:11
Copy link
Contributor

@p7nov p7nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some fixes and suggestions from my side.

@xuniq xuniq force-pushed the 2278-box-ctl-demote branch from 6af5e60 to a77dfd7 Compare October 6, 2022 10:45
@xuniq xuniq merged commit 45e1300 into latest Oct 6, 2022
@xuniq xuniq deleted the 2278-box-ctl-demote branch October 6, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3pt] Add the new box.ctl.demote() entry
3 participants