-
Notifications
You must be signed in to change notification settings - Fork 43
Fixes gh-1650 Add columns to existing tables in SQL #1961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the column name must be unique within the table. | ||
Example with a STRING column that must start with X: |br| | ||
``ALTER TABLE t1 ADD COLUMN s4 STRING CHECK (s4 LIKE 'X%');`` |br| | ||
ALTER TABLE ... ADD COLUMN support was added in version :doc:`2.7.1 </release/2.7.1>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for mentioning the version!
Format code example as code block
@pgulutzan Peter, thanks! There's new deployment magic that I'd like to tell you about. Now we can build the changes in a pull request and preview them on the test website. To deploy a pull request, one should add a While the build is in progress, pull request will have this banner: We're looking at the "Deploy-branch" job. When it's ready, banner will change to this: Now one can click the I've added a link back from the release notes and formatted the code example a little. This commit was already built and deployed, you can have a look. If you're okay with my additions, please merge the pull request. |
I added another link back from the release notes page. Now we are good to go with merging. |
@NickVolynkin: When you say I should add a "build-branch" label, I guess you mean that, for example on this pull request, I should click on "Labels" and then click the branch number, which is 2.7.1 (somebody clicked "deploy-branch" which I guess is not what I should do), okay. I have explained why I believe that adding "code-block:: sql" is generally a bad idea but won't argue about this case. On prior occasions I used the command line to merge, but this time I just clicked the merge button on this site. It seems that I was supposed to put something in the release notes pointing to ALTER TABLE, okay. |
@NickVolynkin: I overlooked two things:
If you do not object, I will simply fix those things and push. |
@pgulutzan please do! |
Warning: not just an .rst change, also an .svg and .spec change.