Skip to content

fix: ACL issue #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 27, 2023
Merged

fix: ACL issue #167

merged 9 commits into from
Apr 27, 2023

Conversation

hayk99
Copy link
Contributor

@hayk99 hayk99 commented Apr 26, 2023

removing ACL block since by default it's private
Adding aws_s3_bucket_ownership_controls to block ACL modifications

Keeping this change https://github.com/sysdiglabs/terraform-aws-secure-for-cloud/pull/164/files since AWS has not yet released the feature so public block access is not enabled by default.

@hayk99 hayk99 requested a review from a team as a code owner April 26, 2023 16:43
@hayk99 hayk99 requested review from acaprari and d-enz April 27, 2023 10:35
d-enz
d-enz previously approved these changes Apr 27, 2023
@hayk99 hayk99 requested a review from d-enz April 27, 2023 14:03
@hayk99 hayk99 merged commit 5305746 into master Apr 27, 2023
@hayk99 hayk99 deleted the fix-acl-issue branch April 27, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants