Skip to content

fix: Require all requests to S3 Bucket to be SSL (PCI.S3.5) and enable encryption at rest (PCI.S3.4) #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 20, 2022
Merged

fix: Require all requests to S3 Bucket to be SSL (PCI.S3.5) and enable encryption at rest (PCI.S3.4) #149

merged 6 commits into from
Dec 20, 2022

Conversation

tembleking
Copy link
Member

@tembleking tembleking commented Dec 13, 2022 •
edited
Loading

Fixes the following PCI issues:

  • [PCI.S3.5] This AWS control checks whether S3 buckets have policies that require requests to use Secure Socket Layer (SSL).
  • [PCI.S3.4] This AWS control checks that your Amazon S3 bucket either has Amazon S3 default encryption enabled or that the S3 bucket policy explicitly denies put-object requests without server side encryption.

@tembleking tembleking requested a review from a team as a code owner December 13, 2022 12:26
@tembleking tembleking self-assigned this Dec 13, 2022
@tembleking tembleking changed the title fix: Require all requests to S3 Bucket to be SSL (PCI.S3.5) fix: Require all requests to S3 Bucket to be SSL (PCI.S3.5) and enable encryption at rest (PCI.S3.4) Dec 15, 2022
@tembleking tembleking enabled auto-merge (squash) December 15, 2022 17:38
jprieto92
jprieto92 previously approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@jprieto92 jprieto92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tembleking

@tembleking tembleking dismissed stale reviews from penguinjournals and jprieto92 via 6241212 December 20, 2022 15:11
jprieto92
jprieto92 previously approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@jprieto92 jprieto92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jprieto92
jprieto92 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@jprieto92 jprieto92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tembleking tembleking merged commit e706d90 into master Dec 20, 2022
@tembleking tembleking deleted the fix-pci-s3-5-require-requests-ssl branch December 20, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprieto92 jprieto92 jprieto92 approved these changes

@penguinjournals penguinjournals penguinjournals left review comments

Assignees

@tembleking tembleking

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tembleking @penguinjournals @jprieto92