Skip to content

fix: improve InclusiveDescendant performance #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Jan 16, 2025

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

microsoft/TypeScript#51188

Tree is never by default, Tree extends Parent is always true in that case, [Tree] extends [Parent] does the trick.

Note

The PR target is v5

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jan 16, 2025
@JounQin JounQin closed this Jan 16, 2025
@JounQin
Copy link
Member Author

JounQin commented Jan 16, 2025

Wrong fix...

This comment has been minimized.

@wooorm wooorm added the 🤷 no/invalid This cannot be acted upon label Jan 16, 2025
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on
Development

Successfully merging this pull request may close these issues.

2 participants