Update zone.js to version 0.6.16 🚀 #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
steveblue
pushed a commit
that referenced
this pull request
Feb 5, 2025
Fixes the issue where tree grouping breaks if rows are directly set on ngx-datatable without doing any async calls.
steveblue
added a commit
that referenced
this pull request
Feb 11, 2025
* fix: tabindex on datatable body * fix: emit page event on page size change for virtual paging (#4) * fix: emit page event on page size change for virtual paging Ensures that the rows (data) are loaded correctly when the layout of the table has changed. This applies especially to changes for resizing the view port which let page size increase or decrease. * perf: don't emit duplicate page events Co-authored-by: Daniel Ritz <[email protected]> * fix: fix CSP script-src 'self' (#5) Original PR: #2005 Fix CSP issue: #1560 Co-authored-by: Denga Andrei <[email protected]> * fix: fix clearTimeout/_destroySubscription race (#6) Before this patch, when an Angular component gets destroyed (e.g. for recreation by parent) while a long-click is in progress, a TypeError could be thrown. Co-authored-by: Dominique Quatravaux <[email protected]> * fix: refresh virtual grid after scroll (#8) See #1798, #1830 Co-authored-by: mikekov <[email protected]> * chore(demo): fix cache in paging-virtual example (#9) * feat: support custom content for empty table (#7) * Fix/column resize (#10) * fix: fix column resizing basic cases Still broken: flex, column pinning * fix: fix flex column resizing See #1495 * fix: make column resize with pinned columns work a bit better * fix: fix orderable directive (#11) See #1814 Co-authored-by: Andrey Korovin <[email protected]> * feat: add custom loading indicator (#13) feat: add custom loading indicator * fix: don't execute sortInternalRows if externalSorting is true (#16) See #1975 Co-authored-by: Gendy <[email protected]> * refactor(custom-empty-component): use custom empty component if existent (#15) Before, the developer had to specify a flag, if the table shall use a custom empty comonent. Now the flag is not needed any more. Makes the API cleaner. Either a custom empty component is available or not. BREAKING-CHANGE: remove usage of emptyCustomContent input * feat: decouple checkboxable and headerCheckboxable from SelectionType.checkbox (#18) This change enables the datatable user to programatically set header checkbox and column checkbox without the need of using the SelectionType.checkbox. This supports use cases by combining multi row selection with an additional checkbox view. * fix: add .angular to gitignore * feat: support angular 13 and eslint * feat: upgrade rxjs 7 * refactor: remove unneeded parseInt() * fix: redraw issue with virtual scroll while dragging scrollbar (#22) * Update body.component.ts * fix lint issues * Update body.component.ts * Update body.component.ts * fix(datatable-redraw): ngx-datatable re-draw issue in context of scroll bar and enabled DOM virtualization (#24) fix redraw issue due to scrollbar with large data * fix(ghost-loaders): add support to ghost loader in ngx-datatable (#21) This will add support to show ghost loading cells default as well as dynamic while paginating data Co-Authored-By: Fabio Huser <[email protected]> Co-authored-by: Fabio Huser <[email protected]> * fix(a11y): add aria-label for datatable tree icons (#27) * feat: enable vertical scrolling on demand (#28) * feat: enable vertical scrolling on demand * style: correct code style issues * fix: correct dynamic vertical scolling (#29) * feat(ngx-datatable): allow support to disable row (#25) * fix: memory leak from loading indicator (#23) Custom loading indicator had a height that was triggering the scroll and could request page loading on server-side virtual scrolling. Now here is a trick. Create a wrapper div, set height to 0. * fix: increase style file budget to meet material theme file (#31) * fix: remove empty placeholder rows after actual data is rendered (#32) * fix: console error with ghostLoadingIndicator (#34) * docs: fixed disabled row demo code link (#35) Co-authored-by: Laxminarayan Chandrashekar <[email protected]> * feat(datatable): allow row drag and drop (#36) * fix: emit drag leave event (#37) * feat(configuration): add `cssClasses`, `headerHeight`, `footerHeight` and `rowHeight` to global configuration (#38) * uninstall sass * support angular 14 * pin node to 18.10.0 * upgrade eslint * support angular 15 * upgrade eslint * support angular 16 * pin node to 18.13.0 * support angular 17 * update peer dependencies * chore(test_and_deploy): update actions and node * chore(test_and_deploy): bump `actions/checkout` to v4 * chore(test_and_deploy): set Node.js version to `lts/iron` See https://github.com/actions/setup-node. * fix(disable-row): allow disabling through side effects without mutating row data (#40) * fix(scaleColumns): adjust for overflow when scaling columns in flex mode (#43) * fix(scaleColumns): adjust for overflow when scaling columns in flex mode * fix(scaleColumns): handle null pointer for biggest column ref * fix(scaleColumns): respect min widths when applying fixes * feat: support keyboard shortcuts for all rows selection (#44) Allows user to select all rows with keyboard `meta+a` or `ctrl+a`. This only selects rows which are currently available to the datatable and will not select rows which get loaded from server in future by user actions like scrolling/paging * fix: emit page objects when changing page offset (#45) Allows to keep external pagination components to be in sync with current page. * fix(footer): move footer outside table role (#47) footer includes pagination which can break a11y rules and shouldn't be part of parent with `role=table`. * fix: prefer unprefixed style attributes over prefixed one (#50) This is to fix an issue on Firefox 126 (released May 2024), which no longer support `-moz-transform` but `transform`. But when we get style attributes from an element, `-moz-transform` is still available, which makes our `testStyle` fails. So to resolve this issue, we want to use unprefixed attribute if available. * fix(header): support tabbing over header cells (#52) * docs: correct-jsdoc-comment (#56) Co-authored-by: Linus Schlumberger <[email protected]> * fix(row-grouping): row selection with grouped rows (#55) * fix(scroll): horizontal scroll is disabled with empty rows (#57) Fixes the issue where it is not possible to scroll horizontally when there is no data causing some columns headers to not be visible. * fix(scroll): extra gap with frozenRight column (#58) Fixes extra gap which appears when using frozenRight and having horizontal scroll enabled along with vertical scroll. * fix(row-grouping): sorting with grouped rows (#53) Co-authored-by: Timo Wolf <[email protected]> * fix(scroll): horizontal scroll with grouped rows (#59) Fixes endless horizontal scroll behaviour when using grouped rows. * feat(rows): wrapper for pre applying directives (#54) * feat(rows): wrapper for pre applying directives Introduced `DatatableRowDefComponent` which can be used by consumers to pre apply certain directives on each row. Usage: ```html <ngx-datatable> <ng-template rowDef> <datatable-row-def cdkDrag /> </ng-template> </ngx-datatable> ``` * chore: add cdk drag example * chore: update docs and fix review feedback * fix(empty-data): use correct width for empty data (#63) * fix(row-group): group header row height (#61) fixes the issue where `rowHeight` on `ngx-datatable-group-header` doesn't work * fix(row-group): group header row height (#61) fixes the issue where `rowHeight` on `ngx-datatable-group-header` doesn't work * feat(sort): support to remove applied sort (#64) Introduced `enableClearingSortState` which allows to clear the sort on particular column after performing ascending and descending sort. * fix: keep sorting on internal rows in sortInternalRows() (#66) * chore: fix lint errors (#65) * chore: run actions on pull_request (#69) * feat(row-group): row group with checkbox (#62) * fix: cyclic import (#71) * feat: include library build in ci * ci(actions): only build project on pull-request events (#72) * fix(disabled-rows): recalculate only if row differs (#73) fixes the issue where `ngDoCheck` goes into infinte loop when `disableRowCheck` is provided. * fix: tree grouping breaks if rows are assigned statically (#77) Fixes the issue where tree grouping breaks if rows are directly set on ngx-datatable without doing any async calls. * fix: `datatable-scroller` width should update on recalculate (#79) * feat: introduce proper types for public API (#49) BREAKING CHANGE: Almost every public API has now proper types. While this should in theory not affect applications it will now fail compilation if the APIs were used in an incorrect manner. * chore: use prettier (#84) * refactor: identify public and internal types and interfaces (#83) BREAKING CHANGE: Change signature from onBodyPage({ offset }: any): void to onBodyPage(offset: number): void * refactor: remove unnecessary getter/setters on columnTemplates * fix: improve types for row grouping * fix: type cell context * fix: improve `ActivateEvent` * refactor: add missing type * fix: align TableColumn directive and interface types * feat: upgrade eslint for angular 18 * fix: pin node * feat: migrate to yarn * fix: revert to node 18 * feat: install local cli for upgrade * feat: support angular 18 * fix: linter * refactor: switch to control flow syntax * refactor: use unique keys for trackBy * refactor: use inject api instead of constructor for DI * refactor: use signals to render internal rows - Switched to use signal for `temp` iterator which was used for rendering the rows on view also renamed `temp` to `rowsToRender`. - `getRowsStyles` and `bottomSummaryRowsStyles` converted to `computed` signals to avoid calling them unnecessarily. This should lead to some performance boost. * refactor: avoid duplicate sort calls * refactor: improve types in utils * refactor: duplicate trackBy index warnings fix to avoid duplicate trackBy index warning thrown when using virtual scroll with ghost loader. * refactor: avoid unnecessary loops only update rowExpansions in case of using row details. * fix: add missing type for header and cell style classes * refactor: use signals for indexes * fix: calculate column widths only when table is visible * refactor: proper types for ghost loader * refactor: move ghost cell template to else block * fix: hide rows when ghostLoading with no virtualization * feat: configurable defaultColumnWidth added property for passing `defaultColumnWidth` with `INgxDatatableConfig` and also aligned `forceFillColumnWidths` to use correct `defaultColumnWidth`. * fix: partial values for messages and cssClasses * refactor: use css sticky instead of transform * refactor: use signals for rowHeightCache * refactor: use built in transform for boolean and number * fix: horizontal scroll horizontal scroll shouldn't appear on load if there is enough space available to render columns. * refactor: remove useless vendor prefix Those prefixes are no longer need as transform and translate are widely available: See: https://caniuse.com/?search=css-transform BREAKING CHANGE: Vendor prefixes are no longer applied for css `transform`. The related helpers are removed from the public api. * refactor: remove unused code * refactor: use fallback content projection * docs: use router instead of ng-if * chore: use control flow syntax for examples * refactor(TSDoc): remove usless @memberof annotations * refactor: convert library modules to standalone * fix: lint and test errors * refactor: provide services where actually needed * fix: update group checkbox state on child row selection state change * refactor: replace keyCode with key value BREAKING CHANGE: changed `Keys` enum to use `key` value instead of `keyCode`. `keyCode` is deprecated from `KeyBoardEvent` and should be replaced with `key`. * build: switch to esbuild * fix: do not bind content as `innerHTML` by default (#126) BREAKING CHANGE: Previously, cell values were bound using `innerHTML`. With this change they are now bound using normal data binding. This means that any html markup will no longer be rendered. To restore the previous behavior set `bindAsUnsafeHtml` on columns where needed. We decided to change this behavior, as binding `innerHTML` can lead to HTML injection. Especially in table content which are often untrusted user generated content. BREAKING CHANGE: Header cell names are now bound using data binding instead of `innerHTML`. Use a `headerTemplate` to provide custom html markup. * refactor: remove useless utils BREAKING CHANGE: removed polyfill for `elementsFromPoint` since `elementsFromPoint` is now supported by all major browsers. * docs: add alt to some very fun images * docs: accessibility issues pertaining to focus * fix: add missing space before headerClass (#138) * build: increase maximumError size limit in angular.json * feat: upgrade angular cli * feat: support angular 19 * feat: version bump * fix: linter * fix: workflow * fix: workflow * fix: remove library build in ci * fix: workflow * fix: workflow * fix: lock * fix: tslib * fix: ci unit tests * fix: dependencies * fix: use nodeLinker * Revert "fix: dependencies" This reverts commit ef46b10. * fix: cleanup eslint --------- Co-authored-by: Silvan Adrian <[email protected]> Co-authored-by: Sandra Freihofer <[email protected]> Co-authored-by: Daniel Ritz <[email protected]> Co-authored-by: Denga Andrei <[email protected]> Co-authored-by: Dominique Quatravaux <[email protected]> Co-authored-by: mikekov <[email protected]> Co-authored-by: Andrey Korovin <[email protected]> Co-authored-by: Shahira Begam <[email protected]> Co-authored-by: Gendy <[email protected]> Co-authored-by: Timo Wolf <[email protected]> Co-authored-by: Timo Wolf <[email protected]> Co-authored-by: chintankavathia <[email protected]> Co-authored-by: Fabio Huser <[email protected]> Co-authored-by: Laxminarayan Chandrashekar <[email protected]> Co-authored-by: Laxminarayan Chandrashekar <[email protected]> Co-authored-by: Maxi <[email protected]> Co-authored-by: Petar Stoyanov <[email protected]> Co-authored-by: Don Nguyen <[email protected]> Co-authored-by: Linus Schlumberger <[email protected]> Co-authored-by: Linus Schlumberger <[email protected]> Co-authored-by: Maximilian Koeller <[email protected]> Co-authored-by: Chintan Kavathia <[email protected]> Co-authored-by: Grant Forsythe <[email protected]> Co-authored-by: Leo Viezens <[email protected]> Co-authored-by: Karan Mistry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
zone.js just published its new version 0.6.16.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of zone.js.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 6 commits .
55f8150chore: Release v0.6.16d38ccdefix(jasmine): spelling error of 'describe' in jasmine patch prevented application of sync zoned4dd351chore: more correct test for jasmine396942bfix(patchProperty): return null as the default value (#413)3b4c20bfix(browser): use XMLHttpRequest.DONE constant on target instead of the global interface (#395)2d4ff65fix long-stack-trace zone will not render correctly when reject a promise (#403)See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade