[cxx-interop] Allow initializing std::map from Swift Dictionary
#75877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds initializers for `std::map` and `std::unordered_map` that take a Swift dictionary as a single parameter. rdar://133691563
egorzhdan
commented
Aug 14, 2024
| public init(_ dictionary: Dictionary<Key, Value>) where Key: Hashable { | ||
| self.init() | ||
| for (key, value) in dictionary { | ||
| self[key] = value |
There was a problem hiding this comment.
As a future performance optimization, we could use __insertUnsafe here to skip the check for the presence of the element in subscript.
There was a problem hiding this comment.
Any reason not to do it in this PR? Are there any concerns about that approach?
There was a problem hiding this comment.
No strong reasons, but I wanted to add a simple benchmark first (in a different PR) to see if the unsafe APIs actually give us any speedup compared to the subscript.
|
@swift-ci please test |
Xazax-hun
approved these changes
Aug 14, 2024
| public init(_ dictionary: Dictionary<Key, Value>) where Key: Hashable { | ||
| self.init() | ||
| for (key, value) in dictionary { | ||
| self[key] = value |
There was a problem hiding this comment.
Any reason not to do it in this PR? Are there any concerns about that approach?
|
@swift-ci please test macOS |
1 similar comment
|
@swift-ci please test macOS |
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initializers for
std::mapandstd::unordered_mapthat take a Swift dictionary as a single parameter.rdar://133691563