Skip to content

[5.9] [Macros] Code item macros #64895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

[5.9] [Macros] Code item macros #64895

merged 1 commit into from
Apr 5, 2023

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Apr 4, 2023 •
edited
Loading

  • Explanation: Add support for declaring and expanding code item macros. Add experimental feature flag CodeItemMacros. Add diagnostics about illegal macro introduced names in @attached and @freestanding attributes.
  • Scope: Declaration sites and use sites of macros declared with @freestanding(codeItem) which was previously not possible, and @attached and @freestanding attribute checking.
  • Issue: rdar://106326121
  • Risk: Low. The new capabilities added here are gated under the CodeItemMacros feature flag.
  • Testing: Tests added for new behavior under the CodeItemMacros feature flag.
  • Reviews: @DougGregor
  • Original pull request: [Macros] Code item macros #64765

@rxwei rxwei requested a review from a team as a code owner April 4, 2023 06:19
@rxwei
Copy link
Contributor Author

rxwei commented Apr 4, 2023

@swift-ci please smoke test

@rxwei rxwei changed the title [Macros] Code item macros [5.9] [Macros] Code item macros Apr 4, 2023
@rxwei
Copy link
Contributor Author

rxwei commented Apr 4, 2023

@swift-ci please test

@ktoso
Copy link
Contributor

ktoso commented Apr 4, 2023

The distributed_actor_custom_executor_availability.swiftCI issue will be resolved by: #64890 (cherry pick: #64891 )

but it seems there was another failure as well.

@rxwei
Copy link
Contributor Author

rxwei commented Apr 4, 2023

Currently blocked on #64873

@rintaro
Copy link
Member

rintaro commented Apr 4, 2023

@swift-ci please test

@rxwei
Copy link
Contributor Author

rxwei commented Apr 4, 2023

@swift-ci please test macos

@rxwei
[Macros] Code item macros
38ff65b 
Add support for declaring and expanding code item macros.  Add experimental feature flag `CodeItemMacros`.
@rxwei
Copy link
Contributor Author

rxwei commented Apr 5, 2023

@swift-ci please test

@DougGregor DougGregor merged commit 9f9e709 into swiftlang:release/5.9 Apr 5, 2023
@rxwei rxwei deleted the 106326121-59 branch April 5, 2023 19:55
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rxwei @ktoso @rintaro @DougGregor @AnthonyLatsis