Change all library types to automatic #1545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
changed the title
kimdv
approved these changes
Apr 14, 2023
ahoppen
force-pushed
the
ahoppen/automatic-libraries
branch
from
065abe6 to
16a55b7
Compare
ahoppen
changed the title
|
@swift-ci Please test |
`automatic` and `static` currently have the same behavior in SwiftPM and we should allow flexibility here, there’s no reason to specify that the libraries need to be `static`.
ahoppen
force-pushed
the
ahoppen/automatic-libraries
branch
from
16a55b7 to
1acbfc3
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
kimdv
approved these changes
Apr 29, 2023
|
@swift-ci Please test |
We can’t build library products if they have library type `automatic`. Instead build their targets. While doing that, I defined a fake target that depends on all targets in the SwiftSyntax package. This way, we can build all targets concurrently, before we were only building `SwiftSyntax` and `SwiftSyntaxBuilder` sequentially. All other targets only got build when running tests.
ahoppen
force-pushed
the
ahoppen/automatic-libraries
branch
from
09e4511 to
a4d2e79
Compare
|
@swift-ci Please test |
|
@swift-ci please test windows |
bnbarham
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
automaticandstaticcurrently have the same behavior in SwiftPM and we should allow flexibility here, there’s no reason to specify that the libraries need to bestatic.