[Commands] AddSetting: Searching for a target in the manifest shouldn… #8699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci please test |
bnbarham
approved these changes
May 19, 2025
|
@swift-ci please test self hosted Windows platform |
dschaefer2
approved these changes
May 21, 2025
|
@swift-ci please test self hosted Windows platform |
xedin
force-pushed
the
fix-findFirst-in-addSetting
branch
from
dc92027 to
de4a631
Compare
|
@swift-ci please test |
…'t walk targets recursively
Otherwise in situations like:
```swift
let package = Package(
name: "packages",
targets: [
.target(
name: "MyTest",
dependencies: [
.byName(name: "Dependency")
]
),
.target(
name: "Dependency"
)
]
)
```
When adding settings to `Dependency` we'd find `.byName(name: "Dependency")`
instead of `.target(name: "Dependency", ...)`.
xedin
force-pushed
the
fix-findFirst-in-addSetting
branch
from
de4a631 to
612cc07
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…'t walk targets recursively
Motivation:
Otherwise in situations like:
When adding settings to
Dependencywe'd find.byName(name: "Dependency")instead of
.target(name: "Dependency", ...).Modifications:
findFirstinAddSwiftSetting.addToTargetwith a custom walk over the targets array.Result:
Find correct element in the manifest "targets" array.