Skip to content

WiX: package up the Testing cross-module overlay #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025

Conversation

compnerd
Copy link
Member

This adds the swift-testing cross-module overlay to the distribution on Windows.

Package the cross module overlay for Testing into the distribution on
Windows for Windows and Android SDKs.
@compnerd compnerd changed the title WiX: package up the cross-module overlay WiX: package up the Testing cross-module overlay Apr 12, 2025
@compnerd
Copy link
Member Author

Tested with a prebuild from https://ci-external.swift.org/job/swift-PR-build-toolchain-windows/5830/artifact/build/artifacts/installer.exe with help from @grynspan

Ran the following snippet:

import Testing
import Foundation

@Test func test() {
  let data = Data()
  Attachment.record(data)
}

@grynspan grynspan requested a review from stmontgomery April 19, 2025 01:04
Copy link
Contributor

@stmontgomery stmontgomery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this looks like what you'd need to get the cross-import overlay working. LGTM, thanks!

@compnerd compnerd merged commit ca4bc79 into swiftlang:main Apr 19, 2025
@compnerd compnerd deleted the cross-module branch April 19, 2025 18:08
@grynspan
Copy link

@compnerd Does this need to be cherry-picked?

@etcwilde
Copy link
Contributor

etcwilde commented Apr 19, 2025

Approved with a note, I don't actually see an accepted proposal for cross-import libraries. The Swift-Testing proposal only references the pitch thread. I'm not sure what the rules are here, but I'm pretty sure that accepted features should only be built on accepted features.

@compnerd
Copy link
Member Author

@grynspan yes, we should cherry-pick this.

@grynspan
Copy link

@etcwilde Cross-import overlays haven't been approved as a supported feature; our use here is necessary because Swift Testing is part of the toolchain and there is a circular dependency between Foundation and Swift Testing if Swift Testing puts these interfaces directly in the main Testing module. @beccadax and colleagues approved this limited use of the feature because of the constraints we're under.

(I'm on leave and won't respond further right now—please ping Becca, @stmontgomery, or @briancroom if you have further questions.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants