Skip to content

"async throws" gets smooshed together in some cases #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
saagarjha opened this issue Jun 4, 2023 · 0 comments · Fixed by #539
Closed

"async throws" gets smooshed together in some cases #538

saagarjha opened this issue Jun 4, 2023 · 0 comments · Fixed by #539

Comments

@saagarjha
Copy link

Before formatting:

var tasks = [(() async throws -> Int)]()

After formatting:

var tasks = [(() asyncthrows -> Int)]()

Notably, this code isn't even valid anymore. I'm using swift-format 508.0.1.
allevato added a commit to allevato/swift-format that referenced this issue Jun 5, 2023
@allevato
Fix async throws function types when they appear in an expression c…
dabb463 
…ontext.

Also unify the way we handle `async throws` now that they are all contained
inside effect specifier nodes that share a common `EffectSpecifiersSyntax`
protocol conformance.

Fixes swiftlang#538.
@allevato allevato mentioned this issue Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix async throws function types when they appear in an expression context. allevato/swift-format
1 participant
@saagarjha