Skip to content

Pass cancelOnSubsequentRequest: 0 to all requests that support it #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 14, 2025

Adopt the option introduced by swiftlang/swift#81507. SourceKit-LSP uses explicit cancellation and perform any implicit cancellation inside sourcekitd.

Fixes #2021
rdar://145871554

@ahoppen ahoppen requested review from bnbarham and hamishknight May 14, 2025 16:45
@ahoppen
Copy link
Member Author

ahoppen commented May 14, 2025

@swift-ci Please test

Adopt the option introduced by swiftlang/swift#81507. SourceKit-LSP uses explicit cancellation and perform any implicit cancellation inside sourcekitd.

Fixes swiftlang#2021
rdar://145871554
@ahoppen ahoppen force-pushed the no-cancel-on-subsequent-request branch from 214bd6d to a909439 Compare May 15, 2025 08:42
@ahoppen
Copy link
Member Author

ahoppen commented May 15, 2025

@swift-ci Please test

@bnbarham
Copy link
Contributor

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constant sourcekitd timeouts in neovim with inlay hints enabled
2 participants