[objc_direct] also go through implementations when looking for clashes #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some methods are sometimes declared in the @implementation blocks which can cause undiagnosed clashes. Just write a checkObjCDirectMethodClashes() for this purpose. Also make sure that "unavailable" selectors do not inherit objc_direct_members. Differential Revision: https://reviews.llvm.org/D76643 Signed-off-by: Pierre Habouzit <[email protected]> Radar-ID: rdar://problem/59332804, rdar://problem/59782963 (cherry picked from commit 20d704a)
|
@swift-ci test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some methods are sometimes declared in the @implementation blocks which
can cause undiagnosed clashes.
Just write a checkObjCDirectMethodClashes() for this purpose.
Also make sure that "unavailable" selectors do not inherit
objc_direct_members.
Differential Revision: https://reviews.llvm.org/D76643
Signed-off-by: Pierre Habouzit [email protected]
Radar-ID: rdar://problem/59332804, rdar://problem/59782963
(cherry picked from commit 20d704a)