Skip to content

format with spaces #3336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

format with spaces #3336

wants to merge 1 commit into from

Conversation

vhscom
Copy link

@vhscom vhscom commented Jan 14, 2022

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

This is a very small opinionated change which will save a lot of developer time and improve display and readability of code when diffing with graphical display tools such as github and gitea. Will there be bikeshedding? Perhaps. Are spaces overwhelmingly the norm for web projects? Yes, unless you're working on Golang.

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2022

⚠️ No Changeset found

Latest commit: 29acc13

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jan 14, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 29acc13

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61e0f6d5708fa40007d45399

@Conduitry
Copy link
Member

Absolutely not.

@Conduitry Conduitry closed this Jan 14, 2022
@vhscom vhscom deleted the align-with-spaces branch January 14, 2022 04:24
@vhscom
Copy link
Author

vhscom commented Jan 14, 2022

Fair enough.

@vhscom
Copy link
Author

vhscom commented Jan 19, 2022

Digging into this more I learned .editorconfig files are picked up by GitHub and Gitea (and others, I presume) and may be used to address the readability concerns in online compare/diff views. Thanks for the nudge @Conduitry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants