Skip to content

I think in directReply should have extraScope too #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

golfapipol
Copy link
Contributor

@golfapipol golfapipol commented Sep 29, 2017

add extraScope on directReply function via 4th parameter
in reply function have it but in directReply that like do the same not have it.

Description

add extraScope on directReply function via 4th parameter
in reply function have it but in directReply that like do the same not have it.

Motivation and Context

I want to use extraScope when call directReply()

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Sep 29, 2017

Coverage Status

Coverage remained the same at 80.495% when pulling 456bd9e on golfapipol:add-extra-scope-direct-reply into d7cf87a on superscriptjs:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants