Skip to content

Added C++ version of MySaw #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 25, 2018
Merged

Added C++ version of MySaw #7

merged 2 commits into from
Jun 25, 2018

Conversation

cianoc
Copy link
Contributor

@cianoc cianoc commented May 7, 2018

I have not renamed the existing MySaw folder because it complicates the pull request.

nhthn
nhthn requested changes May 7, 2018
View reviewed changes
Copy link
Collaborator

@nhthn nhthn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! the only major problem with this is that there's a naming collision with the other MySaw, so there will be problems if someone installs the entire example-plugins directory. could you rename it to MySaw2 please?

@cianoc
Copy link
Contributor Author

cianoc commented May 8, 2018

Renamed. Knew I was forgetting something.

@cianoc
Copy link
Contributor Author

cianoc commented Jun 25, 2018

bump

@nhthn nhthn merged commit d0622ac into supercollider:master Jun 25, 2018
@nhthn
Copy link
Collaborator

nhthn commented Jun 25, 2018

thanks, and sorry about the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhthn nhthn nhthn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cianoc @nhthn