-
-
Notifications
You must be signed in to change notification settings - Fork 286
add import async client #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fakelog - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
These seem a bit redundant when you can import directly from their name spaces already. Most IDEs will even write the |
I'm not sure what you mean by access level. This looks like an IDE warning and not a Python runtime warning. Can you clarify this please? |
python supports access modifiers, although they are not really something strict and the interpreter will not give an error, but they are still there and the IDE highlights this as a warning async - public |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
===========================================
+ Coverage 43.97% 64.76% +20.78%
===========================================
Files 13 13
Lines 332 315 -17
===========================================
+ Hits 146 204 +58
+ Misses 186 111 -75 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. This change will be available on the next release.
I added a simple import of asynchronous functions similar to synchronous ones