Skip to content

add import async client #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2024
Merged

add import async client #760

merged 3 commits into from
Apr 17, 2024

Conversation

fakelog
Copy link
Contributor

@fakelog fakelog commented Apr 11, 2024

I added a simple import of asynchronous functions similar to synchronous ones

@fakelog fakelog requested a review from a team as a code owner April 11, 2024 04:44
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fakelog - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@silentworks
Copy link
Contributor

These seem a bit redundant when you can import directly from their name spaces already. Most IDEs will even write the from ... import ... line for you. The reason the Sync clients are imported in these files is because the library was only sync at first. Adding more aliases will only lead to more confusion especially AClient.

@fakelog
Copy link
Contributor Author

fakelog commented Apr 12, 2024

Most IDEs will even write the from ... import ... line for you.

the problem is the access level

Снимок экрана_20240412_151450

@silentworks
Copy link
Contributor

I'm not sure what you mean by access level. This looks like an IDE warning and not a Python runtime warning. Can you clarify this please?

@fakelog
Copy link
Contributor Author

fakelog commented Apr 13, 2024

Can you clarify this please?

python supports access modifiers, although they are not really something strict and the interpreter will not give an error, but they are still there and the IDE highlights this as a warning

async - public
_async - protected
__async - private

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 64.76%. Comparing base (819ba63) to head (bc3b72f).
Report is 37 commits behind head on main.

Files Patch % Lines
supabase/client.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #760       +/-   ##
===========================================
+ Coverage   43.97%   64.76%   +20.78%     
===========================================
  Files          13       13               
  Lines         332      315       -17     
===========================================
+ Hits          146      204       +58     
+ Misses        186      111       -75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@silentworks silentworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. This change will be available on the next release.

@silentworks silentworks merged commit ad2fe1c into supabase:main Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants