fix: missing json bodies in patch and put requests #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agreed on moving the requests/sync stuff to the
It was supposed to be a temporary measure to provide an easy interface for the supabase users so we could get a release quickly out of the door, but agreed moving this to postgrest would be preferable. |
fedden
reviewed
Aug 18, 2021
| elif method == "patch": | ||
| func = requests.patch | ||
| additional_kwargs = {"json": self.json} | ||
| elif method == "delete": |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes supabase/postgrest-py#7 and #30
Why are we monkey patching postgrest-py here? If we really need to hide the async reality and offer a synchronous interface, can we move it down to the postgrest-py layer so at least it's tested and kept in sync?