Skip to content

Add Storage File API #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 16, 2021
Merged

Add Storage File API #31

merged 9 commits into from
Aug 16, 2021

Conversation

J0
Copy link
Contributor

@J0 J0 commented Jun 13, 2021

What kind of change does this PR introduce?

Adds Storage File API methods, previous PR was too clunky.

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

What needs to be implemented:

  • Upload/Download Files
  • Move Files
  • Create/Delete buckets

Additional context

Add any other context or screenshots.

@abreumatheus
Copy link

Sorry to bother, but any ETA on this?

@J0
Copy link
Contributor Author

J0 commented Jul 22, 2021

No worries, a slot just cleared up so I'll be working on it for the next 3h. ETA... 12h from now perhaps

Update:

Thanks for waiting @abreumatheus! The current branch should support all functions listed in the docs(except .from().update) but it's not in any state to be merged atm. Feel free to use it if you'd like though.

I'll update further tomorrow and film a video with usage instructions. In the meantime, feel free to let me know if you have any requests that you'd like from the interface or anything that you feel could be improved on.

@J0
Copy link
Contributor Author

J0 commented Jul 22, 2021

Notes for myself:

Should be able to use all functions(with exception of update) as is right now. There are four main tasks which need to be done:

  • Modify syntax to match js version (e.g. .from.upload() .from.download() etc)
  • Support update and maybe concurrent upload of files
  • Add actual tests, right now I'm just testing in a jupyter notebook against the js version(in code sandbox)

Will send a version of this for review tomorrow.

^ Adding this to issue tracker.

@J0 J0 marked this pull request as ready for review August 16, 2021 14:22
@J0 J0 merged commit bb98157 into develop Aug 16, 2021
@J0 J0 deleted the j0_add_storage_file_api branch October 24, 2021 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants