-
-
Notifications
You must be signed in to change notification settings - Fork 288
Update Files For new release #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…release Update Files For new release (Sourcery refactored)
… into jl--add-new-release
Codecov Report
@@ Coverage Diff @@
## develop #108 +/- ##
===========================================
- Coverage 51.21% 50.35% -0.87%
===========================================
Files 10 9 -1
Lines 287 282 -5
===========================================
- Hits 147 142 -5
Misses 140 140
Continue to review full report at Codecov.
|
Yeah, v0.1.0 is good for me because the changes of GoTrue Client are breaking changes. |
I will update to gotrue v0.3.0 and fix the wrap |
Now client options class does not make a deep copy in the replace method because local storage is an abstract class and not dict like before
fix: update gotrue version and modify client options class
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 1.11%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Note: v0.1.0 because we added sync/async which is a substantial change in the interface? Not sure about this