Skip to content

Update Files For new release #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 1, 2022
Merged

Update Files For new release #108

merged 17 commits into from
Jan 1, 2022

Conversation

J0
Copy link
Contributor

@J0 J0 commented Dec 29, 2021

Note: v0.1.0 because we added sync/async which is a substantial change in the interface? Not sure about this

@J0 J0 requested a review from a team December 29, 2021 12:44
@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #108 (ba79875) into develop (f29bada) will decrease coverage by 0.86%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #108      +/-   ##
===========================================
- Coverage    51.21%   50.35%   -0.87%     
===========================================
  Files           10        9       -1     
  Lines          287      282       -5     
===========================================
- Hits           147      142       -5     
  Misses         140      140              
Impacted Files Coverage Δ
supabase/lib/realtime_client.py 28.57% <50.00%> (ø)
supabase/__init__.py 100.00% <100.00%> (ø)
supabase/client.py 88.46% <100.00%> (-0.43%) ⬇️
supabase/lib/auth_client.py 100.00% <100.00%> (ø)
supabase/lib/client_options.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29bada...ba79875. Read the comment docs.

@leynier
Copy link
Contributor

leynier commented Dec 29, 2021

Yeah, v0.1.0 is good for me because the changes of GoTrue Client are breaking changes.

@leynier
Copy link
Contributor

leynier commented Dec 29, 2021

I will update to gotrue v0.3.0 and fix the wrap

Joel Lee and others added 5 commits December 29, 2021 22:04
Now client options class does not make a deep copy
in  the replace method because local storage is an
abstract class and not dict like before
fix: update gotrue version and modify client options class
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 1, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.11%.

Quality metrics Before After Change
Complexity 0.95 ⭐ 1.23 ⭐ 0.28 👎
Method Length 32.56 ⭐ 34.09 ⭐ 1.53 👎
Working memory 5.76 ⭐ 6.08 ⭐ 0.32 👎
Quality 84.27% 83.16% -1.11% 👎
Other metrics Before After Change
Lines 429 446 17
Changed files Quality Before Quality After Quality Change
supabase/init.py 98.83% ⭐ 99.00% ⭐ 0.17% 👍
supabase/client.py 85.02% ⭐ 85.78% ⭐ 0.76% 👍
supabase/lib/auth_client.py 83.52% ⭐ 69.42% 🙂 -14.10% 👎
supabase/lib/client_options.py 77.93% ⭐ 66.81% 🙂 -11.12% 👎
supabase/lib/realtime_client.py 85.59% ⭐ 87.32% ⭐ 1.73% 👍
tests/test_client.py 82.51% ⭐ 81.89% ⭐ -0.62% 👎
tests/test_client_options.py 86.22% ⭐ 85.32% ⭐ -0.90% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
supabase/lib/client_options.py ClientOptions.replace 7 ⭐ 74 🙂 11 😞 63.95% 🙂 Extract out complex expressions
supabase/lib/auth_client.py SupabaseAuthClient.__init__ 0 ⭐ 45 ⭐ 15 😞 69.42% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@J0 J0 merged commit ed59912 into develop Jan 1, 2022
@J0 J0 deleted the jl--add-new-release branch January 1, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants