Skip to content

Dev Server crash when upgrade to 11.1.2 #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lyz810 opened this issue Nov 13, 2020 · 3 comments · Fixed by #1718
Closed

Dev Server crash when upgrade to 11.1.2 #1714

lyz810 opened this issue Nov 13, 2020 · 3 comments · Fixed by #1718

Comments

@lyz810
Copy link

lyz810 commented Nov 13, 2020

Current behavior

run script styleguidist server, after reload page, the dev server is crash

To reproduce
1.upgrade to 11.1.2 or 11.1.1, run styleguidist server and open styleguidist in chrome
2.Open chrome console panel
3. type new WebSocket('ws://localhost:6060/sockjs-node') and press enter
4. repeat step3 twice
5. server crash

I found the reason:
#1705 (comment)

I think this should be config in https://github.com/styleguidist/react-styleguidist/blob/master/src/scripts/create-server.ts#L12, no in user webpack.config.js

Expected behavior
server don't crash

@sapegin
Copy link
Member

sapegin commented Nov 17, 2020

Feel free to send a pull request with a fix 👾

@henit
Copy link

henit commented Nov 17, 2020

Seems like same issue here: ECONNRESET right after styleguidist builds (Compiled successfully.) and is opened in the browser, leading to socket communication.

Running on node 14.14.0, npm 6.14.8

If I downgrade to react-styleguidist 11.1.1, no errors.

sapegin pushed a commit that referenced this issue Nov 24, 2020
@styleguidist-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 11.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

sapegin pushed a commit that referenced this issue Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants