Skip to content

build_opt.h not properly generated #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fpistm opened this issue Jun 24, 2022 · 0 comments
Closed

build_opt.h not properly generated #1749

fpistm opened this issue Jun 24, 2022 · 0 comments
Labels
bug 🐛 Something isn't working
Milestone
2.4.0

Comments

@fpistm
Copy link
Member

fpistm commented Jun 24, 2022 •
edited
Loading

There is a regression with build_opt.h generation since 6a167f8

File is simply overwritten instead of being appended to the end of file:

Arduino_Core_STM32/system/extras/prebuild.sh

Line 25 in 319acb3

printf '\n-fmacro-prefix-map=%s=.' "${BOARD_PLATFORM_PATH//\\/\\\\}" > "$BUILD_PATH/sketch/build.opt"

Patch is:

- printf '\n-fmacro-prefix-map=%s=.' "${BOARD_PLATFORM_PATH//\\/\\\\}" > "$BUILD_PATH/sketch/build.opt"
+ printf '\n-fmacro-prefix-map=%s=.' "${BOARD_PLATFORM_PATH//\\/\\\\}" >> "$BUILD_PATH/sketch/build.opt"
@fpistm fpistm added the bug 🐛 Something isn't working label Jun 24, 2022
@fpistm fpistm added this to the 2.3.1/2.4.0 milestone Jun 24, 2022
@fpistm fpistm closed this as completed in e3f4ee4 Jun 24, 2022
cparata pushed a commit to cparata/Arduino_Core_STM32 that referenced this issue Jan 31, 2023
@fpistm @cparata
fix(build_opt): append to the file instead of overwrite
d2b2137 
Fixes stm32duino#1749

Signed-off-by: Frederic Pillon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
1 participant
@fpistm