Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes here are general improvements for our unit tests.
Regenerated visual tests to support vdiffr 0.3.0
Added visual tests for
mcmc_trace()
,mcmc_trace_highlight()
, andmcmc_trace(np = ...)
(trace with rug-plot of divergences). I added these so that I can see if my changes tomcmc_trace()
in Rank histogram #179 affect plot rendering.Fixed problem causing test for
mcmc_recover_scatter()
to fail.This plot gives each facet the same range for x and y. (We want this setup when we are comparing true values to estimates of the true value.) Before the function set the range by pulling the computed ranges from the prebuilt plot, which broke the tests after a ggplot2 update. We now fix this by computing the ranges beforehand and enforcing the ranges by plotting them invisibly with
geom_blank()
Added a visual test to
ppc_violin_grouped()
The tests all run cleanly except for alpha-related warnings and a warning about my R version. The alpha ones are fixed in my changes in #179.