Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

MSI installer: separate product code for Stackless? #52

Closed
ghost opened this issue Jan 9, 2014 · 6 comments
Closed

MSI installer: separate product code for Stackless? #52

ghost opened this issue Jan 9, 2014 · 6 comments
Labels
2.7-slp major proposal stackless python

Comments

@ghost
Copy link

ghost commented Jan 9, 2014

Originally reported by: Anselm Kruis (Bitbucket: akruis, GitHub: akruis)

Previous releases of the Stackless MSI installer used the same product code (an UUID) as the corresponding CPython MSI installer. To my knowledge this makes it impossible/difficult to install CPython and Stackless parallel.

Is there a technical cause for this behaviour? If not, I propose to use different product codes for Stackless.

Probably the simplest way to do so is to increment the last digit of the product code by two. That's the same mechanism, that is already used to get a different product code for the Win64 version. Win64 increases the code by one.
@ghost
Copy link
Author

ghost commented Jan 9, 2014

Original comment by Anselm Kruis (Bitbucket: akruis, GitHub: akruis):

A possible patch: https://bitbucket.org/akruis/fg2python/commits/0f618c7ea5c72f3ac847b696cace5ace472d7241?at=2.7-slp

@ghost
Copy link
Author

ghost commented Jan 10, 2014

Original comment by RMTEW FULL NAME (Bitbucket: rmtew, GitHub: rmtew):

This was done intentionally, because it made things simpler, and the only gain from not doing it was that you couldn't have mainline and stackless python installed at the same time.

I think your proposal is fine by me. @krisvale was also suggesting we go this way several weeks ago, IIRC.

@ghost
Copy link
Author

ghost commented Jan 10, 2014

Original comment by RMTEW FULL NAME (Bitbucket: rmtew, GitHub: rmtew):

Hmm. Maybe put a space between our UUID numbering and mainline's just to be safe. Perhaps a gap of 5 in difference, just in case they use further up the numbering range later on.

@ghost
Copy link
Author

ghost commented Jan 10, 2014

Original comment by Anselm Kruis (Bitbucket: akruis, GitHub: akruis):

Ok, the gap is now 8. Commit is ace7b0e756e0.

@ghost
Copy link
Author

ghost commented Jan 10, 2014

Original comment by Kristján Valur Jónsson (Bitbucket: krisvale, GitHub: kristjanvalur):

I don't know much about these things but if they work, that's super.
Are you working with the build scripts in stackless/tools/pybuild.bat, Anselm?

@ghost
Copy link
Author

ghost commented Nov 6, 2016

Original comment by Anselm Kruis (Bitbucket: akruis, GitHub: akruis):

Removing milestone: 2.7.6-slp (automated comment)

@ghost ghost closed this as completed Sep 24, 2017
akruis pushed a commit that referenced this issue Dec 21, 2017
@Mariatta @vstinner
bpo-29176: Fix name of the _curses.window class (#52) (python#532)
7253ade 
Set name to "_curses.window" instead of "_curses.curses window" (with
a space!?).
(cherry picked from commit 61e2bc7)
akruis pushed a commit that referenced this issue Mar 3, 2018
@vstinner
bpo-29176: Fix name of the _curses.window class (#52)
61e2bc7 
Set name to "_curses.window" instead of "_curses.curses window" (with
a space!?).
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
2.7-slp major proposal stackless python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants