Skip to content

Trino rebuild broke the Docker build #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nightkr opened this issue Jun 19, 2024 · 2 comments · Fixed by #724
Closed

Trino rebuild broke the Docker build #722

nightkr opened this issue Jun 19, 2024 · 2 comments · Fixed by #724
Assignees
@nightkr

Comments

@nightkr
Copy link
Member

nightkr commented Jun 19, 2024

Caused by #687, see https://github.com/stackabletech/docker-images/actions/runs/9546922567
@nightkr nightkr self-assigned this Jun 19, 2024
@nightkr nightkr moved this to Development: In Progress in Stackable Engineering Jun 19, 2024
@nightkr
Copy link
Member Author

nightkr commented Jun 19, 2024

In particular, see https://github.com/stackabletech/docker-images/actions/runs/9546922567/job/26310831110#logs

@nightkr
Copy link
Member Author

nightkr commented Jun 19, 2024

So just compiling Trino itself seems to use around 10-12GB of space (sorry, didn't measure too accurately), which is just about brushing up against GitHub's 14GB limit.

One option would be to use a Large Runner, but in this case we seem to just about make it through the build itself, so we could "solve" it by deleting intermediate build products after the build.

nightkr added a commit that referenced this issue Jun 19, 2024
@nightkr
Slim down Trino build
ff37757 
Drop RPM, clean up intermediate files, avoid some copying

Fixes #722
@nightkr nightkr mentioned this issue Jun 19, 2024
Merged
@nightkr nightkr moved this from Development: In Progress to Development: Done in Stackable Engineering Jun 19, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 19, 2024
@nightkr
Slim down Trino build (#724)
c608e9b 
* Slim down Trino build

Drop RPM, clean up intermediate files, avoid some copying

Fixes #722

* Try deleting all source after Trino is built

* Use tarball output to dedupe jars
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nightkr nightkr

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Slim down Trino build stackabletech/docker-images
1 participant
@nightkr